You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/26 16:06:52 UTC

[GitHub] [pulsar] wmccarley opened a new pull request #7907: Allow disabling HTTP TRACE/TRACK verbs

wmccarley opened a new pull request #7907:
URL: https://github.com/apache/pulsar/pull/7907


   ### Motivation
   
   
   *Pulsar broker's embedded Jetty client does not disable HTTP TRACE and TRACK by default which causes the application to be flagged as insecure in certain corporate environments*
   
   ### Modifications
   
   *Created a new servlet filter: DisableDebugHttpMethodFilter that is attached to the servlets as they are added at startup. I used [this StackOverflow answer](https://stackoverflow.com/a/40990957)* for reference.
   
   ### Verifying this change
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added test case testDisableHttpTraceAndTrackMethods in WebServiceTest class*
   
   ### Does this pull request potentially affect one of the following parts:
   
     - The rest endpoints: (**yes**) -- **the property is set to false by default in broker.conf so it should not introduce any ill side effects in existing environments**
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (**comment in broker.conf**)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] rdhabalia commented on pull request #7907: Allow disabling HTTP TRACE/TRACK verbs

Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #7907:
URL: https://github.com/apache/pulsar/pull/7907#issuecomment-696977533


   @wmccarley  can you please rebase the PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #7907: Allow disabling HTTP TRACE/TRACK verbs

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7907:
URL: https://github.com/apache/pulsar/pull/7907#issuecomment-728646198


   move to 2.8.0 first


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #7907: Allow disabling HTTP TRACE/TRACK verbs

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7907:
URL: https://github.com/apache/pulsar/pull/7907


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] lazybird23 commented on pull request #7907: Allow disabling HTTP TRACE/TRACK verbs

Posted by GitBox <gi...@apache.org>.
lazybird23 commented on pull request #7907:
URL: https://github.com/apache/pulsar/pull/7907#issuecomment-952713586


   currently which branch fixed this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #7907: Allow disabling HTTP TRACE/TRACK verbs

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7907:
URL: https://github.com/apache/pulsar/pull/7907#issuecomment-721700730


   @wmccarley Could you please resolve the conflicts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] rdhabalia commented on pull request #7907: Allow disabling HTTP TRACE/TRACK verbs

Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #7907:
URL: https://github.com/apache/pulsar/pull/7907#issuecomment-696977533


   @wmccarley  can you please rebase the PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org