You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/02/13 15:32:35 UTC
[GitHub] rabbah commented on a change in pull request #4279: Fix typos in
docs
rabbah commented on a change in pull request #4279: Fix typos in docs
URL: https://github.com/apache/incubator-openwhisk/pull/4279#discussion_r256448033
##########
File path: docs/actions-docker.md
##########
@@ -105,7 +105,7 @@ The instructions that follow show you how to use the OpenWhisk Docker skeleton.
Notice the use of `--docker` when creating an action. Currently all Docker images are assumed
to be hosted on Docker Hub.
- *Note:* It is considered best-practice for production images to be versioned via docker image tags. The absence of a tag will be treated the same as using the tag "latest", which will guarantee to pull from the registry when creating new containers. That contains the possibility of failing because pulling the image fails. For tagged images however, the system will allow a failing pull and gracefully recover it by using the image that is already locally available, making it much more resilient against Dockerhub outages etc.
+ *Note:* It is considered best-practice for production images to be versioned via docker image tags. The absence of a tag will be treated the same as using the tag "latest", which will guarantee to pull from the registry when creating new containers. That contains the possibility of failing because pulling the image fails. For tagged images however, the system will allow a failing pull and gracefully recover it by using the image that is already locally available, making it much more resilient against Docker Hub outages etc.
Review comment:
Can you reword this “Which will guarantee to pull...” and the sentence after it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services