You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Chris Wilkes (JIRA)" <ji...@apache.org> on 2008/10/22 02:06:44 UTC

[jira] Created: (JCR-1827) SessionImpl should have @PreDestroy annotation a method to shut down cleanly from within container

SessionImpl should have @PreDestroy annotation a method to shut down cleanly from within container
--------------------------------------------------------------------------------------------------

                 Key: JCR-1827
                 URL: https://issues.apache.org/jira/browse/JCR-1827
             Project: Jackrabbit
          Issue Type: New Feature
    Affects Versions: core 1.4.6
            Reporter: Chris Wilkes


I'm using Spring and noticed that when I use an ObservationManager to register an eventListener tomcat doesn't shut down properly as the ClientEventPoll thread is still running.  What I've done is annotate a method with the javax @PreDestroy annotation to unregister all listeners and to also call .terminate() on the ClientEventPoll in the ClientObservationManager.

Ideally this would be done in SessionImpl so that it could go through all the Workspaces and do the same.

@PreDestroy is a standard java annotation and isn't tied to spring or tomcat.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (JCR-1827) SessionImpl should have @PreDestroy annotation a method to shut down cleanly from within container

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-1827.
--------------------------------

      Assignee: Jukka Zitting
    Resolution: Won't Fix

Resolving as Won't Fix since the @PreDestroy annotation is not available in Java SE 1.5 and IMHO such extra resource management support should ideally be the responsibility of the client application or a container integration layer.

> SessionImpl should have @PreDestroy annotation a method to shut down cleanly from within container
> --------------------------------------------------------------------------------------------------
>
>                 Key: JCR-1827
>                 URL: https://issues.apache.org/jira/browse/JCR-1827
>             Project: Jackrabbit Content Repository
>          Issue Type: New Feature
>          Components: jackrabbit-core
>    Affects Versions: core 1.4.6
>            Reporter: Chris Wilkes
>            Assignee: Jukka Zitting
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> I'm using Spring and noticed that when I use an ObservationManager to register an eventListener tomcat doesn't shut down properly as the ClientEventPoll thread is still running.  What I've done is annotate a method with the javax @PreDestroy annotation to unregister all listeners and to also call .terminate() on the ClientEventPoll in the ClientObservationManager.
> Ideally this would be done in SessionImpl so that it could go through all the Workspaces and do the same.
> @PreDestroy is a standard java annotation and isn't tied to spring or tomcat.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (JCR-1827) SessionImpl should have @PreDestroy annotation a method to shut down cleanly from within container

Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641734#action_12641734 ] 

Alexander Klimetschek commented on JCR-1827:
--------------------------------------------

Jackrabbit currently is still Java 1.4 compatible, so we cannot use annotations (yet). And this annotation requires a J2EE container. There should be another mechanism for proper shutdown. Apart from that, I wonder why this hasn't been noticed before.

> SessionImpl should have @PreDestroy annotation a method to shut down cleanly from within container
> --------------------------------------------------------------------------------------------------
>
>                 Key: JCR-1827
>                 URL: https://issues.apache.org/jira/browse/JCR-1827
>             Project: Jackrabbit
>          Issue Type: New Feature
>    Affects Versions: core 1.4.6
>            Reporter: Chris Wilkes
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> I'm using Spring and noticed that when I use an ObservationManager to register an eventListener tomcat doesn't shut down properly as the ClientEventPoll thread is still running.  What I've done is annotate a method with the javax @PreDestroy annotation to unregister all listeners and to also call .terminate() on the ClientEventPoll in the ClientObservationManager.
> Ideally this would be done in SessionImpl so that it could go through all the Workspaces and do the same.
> @PreDestroy is a standard java annotation and isn't tied to spring or tomcat.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (JCR-1827) SessionImpl should have @PreDestroy annotation a method to shut down cleanly from within container

Posted by "angela (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated JCR-1827:
------------------------

    Component/s: jackrabbit-core

> SessionImpl should have @PreDestroy annotation a method to shut down cleanly from within container
> --------------------------------------------------------------------------------------------------
>
>                 Key: JCR-1827
>                 URL: https://issues.apache.org/jira/browse/JCR-1827
>             Project: Jackrabbit Content Repository
>          Issue Type: New Feature
>          Components: jackrabbit-core
>    Affects Versions: core 1.4.6
>            Reporter: Chris Wilkes
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> I'm using Spring and noticed that when I use an ObservationManager to register an eventListener tomcat doesn't shut down properly as the ClientEventPoll thread is still running.  What I've done is annotate a method with the javax @PreDestroy annotation to unregister all listeners and to also call .terminate() on the ClientEventPoll in the ClientObservationManager.
> Ideally this would be done in SessionImpl so that it could go through all the Workspaces and do the same.
> @PreDestroy is a standard java annotation and isn't tied to spring or tomcat.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.