You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "drpmma (via GitHub)" <gi...@apache.org> on 2023/06/14 06:36:55 UTC
[GitHub] [rocketmq] drpmma opened a new pull request, #6901: Add attributesBuilderSupplier for BrokerMetricsManager
drpmma opened a new pull request, #6901:
URL: https://github.com/apache/rocketmq/pull/6901
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #6900
### Brief Description
Add attributesBuilderSupplier for BrokerMetricsManager for the extension.
### How Did You Test This Change?
Unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ferrirW commented on pull request #6901: Add attributesBuilderSupplier for BrokerMetricsManager
Posted by "ferrirW (via GitHub)" <gi...@apache.org>.
ferrirW commented on PR #6901:
URL: https://github.com/apache/rocketmq/pull/6901#issuecomment-1591187411
What are the benefits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] drpmma commented on pull request #6901: Add attributesBuilderSupplier for BrokerMetricsManager
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma commented on PR #6901:
URL: https://github.com/apache/rocketmq/pull/6901#issuecomment-1592236202
> What are the benefits?
It is merely for the sake of facilitating the expansion of the `attributesBuilderSupplier`. Furthermore, it has already been present within the codebase.
For instance, consider https://github.com/apache/rocketmq/blob/aea5811df007c2abf2d46eea931e4c867514e0eb/broker/src/main/java/org/apache/rocketmq/broker/metrics/PopMetricsManager.java#L58-L59 and https://github.com/apache/rocketmq/blob/aea5811df007c2abf2d46eea931e4c867514e0eb/store/src/main/java/org/apache/rocketmq/store/metrics/DefaultStoreMetricsManager.java#L54-L55
Simply perform the identical action for the `BrokerMetricsManager`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6901: Add attributesBuilderSupplier for BrokerMetricsManager
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6901:
URL: https://github.com/apache/rocketmq/pull/6901#issuecomment-1590589467
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6901?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#6901](https://app.codecov.io/gh/apache/rocketmq/pull/6901?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1d2771e) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/aaa4a4b5fcc1f3b395264375b9067303820cd38c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (aaa4a4b) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 1d2771e differs from pull request most recent head af9ae23. Consider uploading reports for the commit af9ae23 to get more accurate results
```diff
@@ Coverage Diff @@
## develop #6901 +/- ##
=============================================
+ Coverage 42.64% 42.66% +0.01%
- Complexity 9106 9109 +3
=============================================
Files 1127 1127
Lines 79942 79944 +2
Branches 10392 10392
=============================================
+ Hits 34094 34107 +13
+ Misses 41572 41563 -9
+ Partials 4276 4274 -2
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6901?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../rocketmq/broker/metrics/BrokerMetricsManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/6901?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbWV0cmljcy9Ccm9rZXJNZXRyaWNzTWFuYWdlci5qYXZh) | `12.23% <100.00%> (+0.54%)` | :arrow_up: |
... and [26 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6901/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] drpmma merged pull request #6901: Add attributesBuilderSupplier for BrokerMetricsManager
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma merged PR #6901:
URL: https://github.com/apache/rocketmq/pull/6901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org