You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2018/02/08 01:19:55 UTC
[3/3] groovy git commit: Trivial refactoring: Refine
`getMethodDescriptor`
Trivial refactoring: Refine `getMethodDescriptor`
(cherry picked from commit 7c4aebb)
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/c102ce36
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/c102ce36
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/c102ce36
Branch: refs/heads/GROOVY_2_6_X
Commit: c102ce3666650939ebf7692734d47a0af7de8491
Parents: e89f8a0
Author: sunlan <su...@apache.org>
Authored: Thu Feb 8 07:37:39 2018 +0800
Committer: sunlan <su...@apache.org>
Committed: Thu Feb 8 09:19:49 2018 +0800
----------------------------------------------------------------------
.../codehaus/groovy/classgen/asm/BytecodeHelper.java | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/groovy/blob/c102ce36/src/main/java/org/codehaus/groovy/classgen/asm/BytecodeHelper.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/codehaus/groovy/classgen/asm/BytecodeHelper.java b/src/main/java/org/codehaus/groovy/classgen/asm/BytecodeHelper.java
index af464f4..197ac9c 100644
--- a/src/main/java/org/codehaus/groovy/classgen/asm/BytecodeHelper.java
+++ b/src/main/java/org/codehaus/groovy/classgen/asm/BytecodeHelper.java
@@ -75,9 +75,10 @@ public class BytecodeHelper implements Opcodes {
}
public static String getMethodDescriptor(ClassNode returnType, Parameter[] parameters) {
- StringBuilder buffer = new StringBuilder("(");
- for (int i = 0; i < parameters.length; i++) {
- buffer.append(getTypeDescription(parameters[i].getType()));
+ StringBuilder buffer = new StringBuilder(100);
+ buffer.append("(");
+ for (Parameter parameter : parameters) {
+ buffer.append(getTypeDescription(parameter.getType()));
}
buffer.append(")");
buffer.append(getTypeDescription(returnType));
@@ -99,9 +100,10 @@ public class BytecodeHelper implements Opcodes {
*/
public static String getMethodDescriptor(Class returnType, Class[] paramTypes) {
// lets avoid class loading
- StringBuilder buffer = new StringBuilder("(");
- for (int i = 0; i < paramTypes.length; i++) {
- buffer.append(getTypeDescription(paramTypes[i]));
+ StringBuilder buffer = new StringBuilder(100);
+ buffer.append("(");
+ for (Class paramType : paramTypes) {
+ buffer.append(getTypeDescription(paramType));
}
buffer.append(")");
buffer.append(getTypeDescription(returnType));