You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shale.apache.org by "Hasan Turksoy (JIRA)" <ji...@apache.org> on 2007/05/03 09:44:43 UTC
[jira] Created: (SHALE-441) validator script should not be
generated for child components inside not rendered or not editable or not
enabled parent component.
validator script should not be generated for child components inside not rendered or not editable or not enabled parent component.
----------------------------------------------------------------------------------------------------------------------------------
Key: SHALE-441
URL: https://issues.apache.org/struts/browse/SHALE-441
Project: Shale
Issue Type: Bug
Components: Validator
Affects Versions: 1.0.4
Environment: jsf 1.1, commons-validator 1.3.1
Reporter: Hasan Turksoy
A mail at user mailing list exists about this issue: http://www.nabble.com/-validator--possible-bug-in-validator-script-generation-for-child-comp.-inside-not-rendered-parent-comp.-tf3681172.html
ValidatorScript class is generating scripts only for (editable AND rendered AND [not disabled or readonly]) fields... this is ok.. issue is; if i put a validator for a component comforming above conditions but inside a parent component not comforming above condition, it's still generating scripts for that field... but when parent not rendered, my child component won't be rendered too. In this case, generated scripts throw javascript errors since they can not find the related field to validate...
Suppose i have a text box with a validator inside... if i use this textbox directly, it should generate validation script for this field... But if i put this textbox inside a NOT RENDERED panel, it shouldn't generate validation scripts for my textbox... like below case;
<h:panelGroup rendered="false"> // child components won't be rendered because parent's not rendered
<h:inputText id="txt_name" ....>
<s:commonsValidator type="required" arg="Name" server="true" client="true" />
</h:inputText>
</h:panelGroup>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (SHALE-441) validator script should not be
generated for child components inside not rendered or not editable or not
enabled parent component.
Posted by "Gary VanMatre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/SHALE-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on SHALE-441 started by Gary VanMatre.
> validator script should not be generated for child components inside not rendered or not editable or not enabled parent component.
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHALE-441
> URL: https://issues.apache.org/struts/browse/SHALE-441
> Project: Shale
> Issue Type: Bug
> Components: Validator
> Affects Versions: 1.0.4
> Environment: jsf 1.1, commons-validator 1.3.1
> Reporter: Hasan Turksoy
> Assigned To: Gary VanMatre
>
> A mail at user mailing list exists about this issue: http://www.nabble.com/-validator--possible-bug-in-validator-script-generation-for-child-comp.-inside-not-rendered-parent-comp.-tf3681172.html
> ValidatorScript class is generating scripts only for (editable AND rendered AND [not disabled or readonly]) fields... this is ok.. issue is; if i put a validator for a component comforming above conditions but inside a parent component not comforming above condition, it's still generating scripts for that field... but when parent not rendered, my child component won't be rendered too. In this case, generated scripts throw javascript errors since they can not find the related field to validate...
> Suppose i have a text box with a validator inside... if i use this textbox directly, it should generate validation script for this field... But if i put this textbox inside a NOT RENDERED panel, it shouldn't generate validation scripts for my textbox... like below case;
> <h:panelGroup rendered="false"> // child components won't be rendered because parent's not rendered
> <h:inputText id="txt_name" ....>
> <s:commonsValidator type="required" arg="Name" server="true" client="true" />
> </h:inputText>
> </h:panelGroup>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SHALE-441) validator script should not be
generated for child components inside not rendered or not editable or not
enabled parent component.
Posted by "Gary VanMatre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/SHALE-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary VanMatre reassigned SHALE-441:
-----------------------------------
Assignee: Gary VanMatre
> validator script should not be generated for child components inside not rendered or not editable or not enabled parent component.
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHALE-441
> URL: https://issues.apache.org/struts/browse/SHALE-441
> Project: Shale
> Issue Type: Bug
> Components: Validator
> Affects Versions: 1.0.4
> Environment: jsf 1.1, commons-validator 1.3.1
> Reporter: Hasan Turksoy
> Assigned To: Gary VanMatre
>
> A mail at user mailing list exists about this issue: http://www.nabble.com/-validator--possible-bug-in-validator-script-generation-for-child-comp.-inside-not-rendered-parent-comp.-tf3681172.html
> ValidatorScript class is generating scripts only for (editable AND rendered AND [not disabled or readonly]) fields... this is ok.. issue is; if i put a validator for a component comforming above conditions but inside a parent component not comforming above condition, it's still generating scripts for that field... but when parent not rendered, my child component won't be rendered too. In this case, generated scripts throw javascript errors since they can not find the related field to validate...
> Suppose i have a text box with a validator inside... if i use this textbox directly, it should generate validation script for this field... But if i put this textbox inside a NOT RENDERED panel, it shouldn't generate validation scripts for my textbox... like below case;
> <h:panelGroup rendered="false"> // child components won't be rendered because parent's not rendered
> <h:inputText id="txt_name" ....>
> <s:commonsValidator type="required" arg="Name" server="true" client="true" />
> </h:inputText>
> </h:panelGroup>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHALE-441) validator script should not be
generated for child components inside not rendered or not editable or not
enabled parent component.
Posted by "Gary VanMatre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/SHALE-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary VanMatre updated SHALE-441:
--------------------------------
Attachment: validator.patch
Attached the patch applied to the trunk in the event that we want to apply to the 1_0_x branch.
> validator script should not be generated for child components inside not rendered or not editable or not enabled parent component.
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHALE-441
> URL: https://issues.apache.org/struts/browse/SHALE-441
> Project: Shale
> Issue Type: Bug
> Components: Validator
> Affects Versions: 1.0.4
> Environment: jsf 1.1, commons-validator 1.3.1
> Reporter: Hasan Turksoy
> Assigned To: Gary VanMatre
> Attachments: validator.patch
>
>
> A mail at user mailing list exists about this issue: http://www.nabble.com/-validator--possible-bug-in-validator-script-generation-for-child-comp.-inside-not-rendered-parent-comp.-tf3681172.html
> ValidatorScript class is generating scripts only for (editable AND rendered AND [not disabled or readonly]) fields... this is ok.. issue is; if i put a validator for a component comforming above conditions but inside a parent component not comforming above condition, it's still generating scripts for that field... but when parent not rendered, my child component won't be rendered too. In this case, generated scripts throw javascript errors since they can not find the related field to validate...
> Suppose i have a text box with a validator inside... if i use this textbox directly, it should generate validation script for this field... But if i put this textbox inside a NOT RENDERED panel, it shouldn't generate validation scripts for my textbox... like below case;
> <h:panelGroup rendered="false"> // child components won't be rendered because parent's not rendered
> <h:inputText id="txt_name" ....>
> <s:commonsValidator type="required" arg="Name" server="true" client="true" />
> </h:inputText>
> </h:panelGroup>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHALE-441) validator script should not be
generated for child components inside not rendered or not editable or not
enabled parent component.
Posted by "Gary VanMatre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/SHALE-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41092 ]
Gary VanMatre commented on SHALE-441:
-------------------------------------
This patch will give better coverage for the scenario described in (SHALE-441) but still will not handle the case when a parent or commons validator owner is a child of a UIData component. This test can only be performed at render time. Due to (SHALE-442), I didn't feel comfortable with expanding the ideal of renderer wrappers.
> validator script should not be generated for child components inside not rendered or not editable or not enabled parent component.
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHALE-441
> URL: https://issues.apache.org/struts/browse/SHALE-441
> Project: Shale
> Issue Type: Bug
> Components: Validator
> Affects Versions: 1.0.4
> Environment: jsf 1.1, commons-validator 1.3.1
> Reporter: Hasan Turksoy
> Assigned To: Gary VanMatre
>
> A mail at user mailing list exists about this issue: http://www.nabble.com/-validator--possible-bug-in-validator-script-generation-for-child-comp.-inside-not-rendered-parent-comp.-tf3681172.html
> ValidatorScript class is generating scripts only for (editable AND rendered AND [not disabled or readonly]) fields... this is ok.. issue is; if i put a validator for a component comforming above conditions but inside a parent component not comforming above condition, it's still generating scripts for that field... but when parent not rendered, my child component won't be rendered too. In this case, generated scripts throw javascript errors since they can not find the related field to validate...
> Suppose i have a text box with a validator inside... if i use this textbox directly, it should generate validation script for this field... But if i put this textbox inside a NOT RENDERED panel, it shouldn't generate validation scripts for my textbox... like below case;
> <h:panelGroup rendered="false"> // child components won't be rendered because parent's not rendered
> <h:inputText id="txt_name" ....>
> <s:commonsValidator type="required" arg="Name" server="true" client="true" />
> </h:inputText>
> </h:panelGroup>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.