You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2017/05/15 19:27:04 UTC

[jira] [Commented] (MCOMPILER-286) Detect if dependencies should be added to classpath or modulpath

    [ https://issues.apache.org/jira/browse/MCOMPILER-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011178#comment-16011178 ] 

Hudson commented on MCOMPILER-286:
----------------------------------

FAILURE: Integrated in Jenkins build maven-plugins #8959 (See [https://builds.apache.org/job/maven-plugins/8959/])
[MCOMPILER-294] replace -Xmodule with --patch-module
[MCOMPILER-293] Add advice message in case automodules are used
[MCOMPILER-286] Detect if dependencies should be added to classpath or modulepath (rfscholte: [http://svn.apache.org/viewvc/?view=rev&rev=1795232])
* (edit) maven-compiler-plugin/pom.xml
* (edit) maven-compiler-plugin/src/it/automodules-application/invoker.properties
* (edit) maven-compiler-plugin/src/it/automodules-application/src/main/java/org/maven/test/Main.java
* (edit) maven-compiler-plugin/src/it/automodules-library/invoker.properties
* (edit) maven-compiler-plugin/src/it/automodules-library/src/main/java/org/maven/test/Main.java
* (add) maven-compiler-plugin/src/it/automodules-manifest
* (add) maven-compiler-plugin/src/it/automodules-manifest/invoker.properties
* (add) maven-compiler-plugin/src/it/automodules-manifest/pom.xml
* (add) maven-compiler-plugin/src/it/automodules-manifest/src
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main/java
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main/java/module-info.java
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org/maven
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org/maven/test
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org/maven/test/Main.java
* (add) maven-compiler-plugin/src/it/automodules-manifest/verify.groovy
* (add) maven-compiler-plugin/src/it/automodules-transitive-module
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/invoker.properties
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/pom.xml
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/module-info.java
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org/maven
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org/maven/test
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org/maven/test/Main.java
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/verify.groovy
* (add) maven-compiler-plugin/src/it/setup_jar_automodule
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/pom.xml
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java/com/ta3
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java/com/ta3/MyClass.java
* (add) maven-compiler-plugin/src/it/setup_jar_classic
* (add) maven-compiler-plugin/src/it/setup_jar_classic/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_jar_classic/pom.xml
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java/com/ta2
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java/com/ta2/MyClass.java
* (add) maven-compiler-plugin/src/it/setup_jar_module
* (add) maven-compiler-plugin/src/it/setup_jar_module/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_jar_module/pom.xml
* (add) maven-compiler-plugin/src/it/setup_jar_module/src
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java/com/ta2
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java/com/ta2/MyClass.java
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java/module-info.java
* (add) maven-compiler-plugin/src/it/setup_module-transitive
* (add) maven-compiler-plugin/src/it/setup_module-transitive/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_module-transitive/pom.xml
* (add) maven-compiler-plugin/src/it/setup_module-transitive/src
* (add) maven-compiler-plugin/src/it/setup_module-transitive/src/main
* (add) maven-compiler-plugin/src/it/setup_module-transitive/src/main/java
* (add) maven-compiler-plugin/src/it/setup_module-transitive/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_module-transitive/src/main/java/com/ta2
* (add) maven-compiler-plugin/src/it/setup_module-transitive/src/main/java/com/ta2/plus
* (add) maven-compiler-plugin/src/it/setup_module-transitive/src/main/java/com/ta2/plus/MyClass.java
* (add) maven-compiler-plugin/src/it/setup_module-transitive/src/main/java/module-info.java
* (edit) maven-compiler-plugin/src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java
* (edit) maven-compiler-plugin/src/main/java/org/apache/maven/plugin/compiler/TestCompilerMojo.java
* (edit) maven-compiler-plugin/src/main/java/org/apache/maven/plugin/compiler/module/AsmModuleInfoParser.java
* (edit) maven-compiler-plugin/src/main/java/org/apache/maven/plugin/compiler/module/ProjectAnalyzer.java
* (edit) maven-compiler-plugin/src/main/java/org/apache/maven/plugin/compiler/module/ProjectAnalyzerResult.java


> Detect if dependencies should be added to classpath or modulpath
> ----------------------------------------------------------------
>
>                 Key: MCOMPILER-286
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-286
>             Project: Maven Compiler Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.6.0, 3.6.1
>            Reporter: Robert Scholte
>            Assignee: Robert Scholte
>              Labels: jigsaw
>
> With 3.6.0 if the project is a module all the dependencies end up on the modulepath. 
> It would be better to analyze every module-info.class (requires up to date ASM) and verify per dependency if it is part of the module requirements (both direct and transitive). The rest ends up on the classpath.
> Auto modules are a special chapter. Right now I would ignore auto modules to prevent collisions. Instead one could define the G:As explicitly to be added to the modulePath.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)