You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by "kojiromike (via GitHub)" <gi...@apache.org> on 2023/08/18 01:55:27 UTC
[GitHub] [avro] kojiromike commented on a diff in pull request #2448: AVRO-3833: [Spec] Clarify usage of names and aliases
kojiromike commented on code in PR #2448:
URL: https://github.com/apache/avro/pull/2448#discussion_r1297906498
##########
doc/content/en/docs/++version++/Specification/_index.md:
##########
@@ -180,9 +180,9 @@ For example, 16-byte quantity may be declared with:
```
### Names {#names}
-Record, enums and fixed are named types. Each has a fullname that is composed of two parts; a name and a namespace, separated by a dot. Equality of names is defined on the fullname.
+Record, enums and fixed are named types. Each has a fullname that is composed of two parts; a name and a namespace, separated by a dot. Equality of names is defined on the fullname: it is an error to specify two different types with the same name.
Review Comment:
```suggestion
Record, enums and fixed are named types. Each has a fullname that is composed of two parts: a name and a namespace, separated by a dot. Equality of names is defined on the fullname–it is an error to specify two different types with the same name.
```
##########
doc/content/en/docs/++version++/Specification/_index.md:
##########
@@ -180,9 +180,9 @@ For example, 16-byte quantity may be declared with:
```
### Names {#names}
-Record, enums and fixed are named types. Each has a fullname that is composed of two parts; a name and a namespace, separated by a dot. Equality of names is defined on the fullname.
+Record, enums and fixed are named types. Each has a fullname that is composed of two parts; a name and a namespace, separated by a dot. Equality of names is defined on the fullname: it is an error to specify two different types with the same name.
Review Comment:
```suggestion
Record, enums and fixed are named types. Each has a fullname that is composed of two parts: a name and a namespace, separated by a dot. Equality of names is defined on the fullname–it is an error to specify two different types with the same name.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org