You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/07 18:01:04 UTC

[GitHub] [beam] johnjcasey commented on a diff in pull request #24436: [CdapIO] CdapIO and SparkReceiverIO updates

johnjcasey commented on code in PR #24436:
URL: https://github.com/apache/beam/pull/24436#discussion_r1042521543


##########
sdks/java/io/cdap/src/main/java/org/apache/beam/sdk/io/cdap/context/FailureCollectorWrapper.java:
##########
@@ -41,6 +44,21 @@ public ValidationFailure addFailure(String message, @Nullable String correctiveA
 
   @Override
   public ValidationException getOrThrowException() throws ValidationException {
+
+    // We skip schema field validation errors because they are CDAP oriented and don't affect
+    // anything in our case
+    for (Iterator<ValidationFailure> failureIterator = failuresCollection.iterator();

Review Comment:
   Can we restructure this loop to not depend on an iterator?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org