Re: [PR] [SPARK-53209][YARN] Add ActiveProcessorCount JVM option to YARN executor and AM [spark]

["mridulm (via GitHub)" <gi...@apache.org>]

mridulm commented on code in PR #51948:
URL: https://github.com/apache/spark/pull/51948#discussion_r2594693433


##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -2900,4 +2900,14 @@ package object config {
       .checkValue(v => v.forall(Set("stdout", "stderr").contains),
         "The value only can be one or more of 'stdout, stderr'.")
       .createWithDefault(Seq("stdout", "stderr"))
+
+  private[spark] val LIMIT_ACTIVE_PROCESSOR_COUNT =
+    ConfigBuilder("spark.yarn.limitActiveProcessorCount")
+      .internal()
+      .doc("Whether to limit what the JVM sees for the number of cores set by the user " +
+          "(spark.driver.cores or spark.executor.cores) by \"-XX:ActiveProcessorCount\". " +
+          "This flag only takes effect on YARN.")
+      .version("4.1.1")
+      .booleanConf
+      .createWithDefault(false)

Review Comment:
   QQ: Why does this need to be limited to YARN ?
   Is it not applicable to other resource managers ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org