You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/08/13 10:32:53 UTC

[GitHub] [drill] arina-ielchiieva commented on issue #1841: Drill-7344: Add Geo-IP Functions

arina-ielchiieva commented on issue #1841: Drill-7344: Add Geo-IP Functions
URL: https://github.com/apache/drill/pull/1841#issuecomment-520781600
 
 
   @cgivre if you want to include PR #1840 and #1841 into the upcoming release, please rework these PRs to have proper error handling, to comply with Drill coding style etc. There were similar PRs which undergo the review and have been merged, you can take a look at the code and make appropriate changed. I think it's more reasonable than making code reviewers pointing at the same issues over and over again :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services