You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@couchdb.apache.org by hannes <le...@yahoo.de.INVALID> on 2021/05/25 12:40:44 UTC

new operators $sizeLte and $sizeGte to mango selector

Hello couchdb devs,

I would like to add operators $sizeGte and $sizeLte to the mango 
selector language.

Example: It solves the problem of selecting documents with at least 10 
customers and at most 20 customers in the customers array.

I have created a PR here
- https://github.com/apache/couchdb/pull/3582

Any feedback and help welcome.

best,
Hannes Klarner.

Re: new operators $sizeLte and $sizeGte to mango selector

Posted by Glynn Bird <gl...@apache.org>.

I've commented in the pull request:
https://github.com/apache/couchdb/pull/3582#issuecomment-848792131

On Wed, 26 May 2021 at 14:30, Garren Smith <ga...@apache.org> wrote:

> Hi Hannes,
>
> First off, thank you for contributing the PR. The code looks good, I have
> commented that we need two more tests.
> In terms of the operator, I'm not 100% sure of the use of the operator. I
> would like to see what other CouchDB committers think the of new operator.
>
> Cheers
> Garren
>
> On Tue, May 25, 2021 at 2:46 PM hannes <le...@yahoo.de.invalid> wrote:
>
> > Hello couchdb devs,
> >
> > I would like to add operators $sizeGte and $sizeLte to the mango
> > selector language.
> >
> > Example: It solves the problem of selecting documents with at least 10
> > customers and at most 20 customers in the customers array.
> >
> > I have created a PR here
> > - https://github.com/apache/couchdb/pull/3582
> >
> > Any feedback and help welcome.
> >
> > best,
> > Hannes Klarner.
> >
>

Re: new operators $sizeLte and $sizeGte to mango selector

Posted by Garren Smith <ga...@apache.org>.

Hi Hannes,

First off, thank you for contributing the PR. The code looks good, I have
commented that we need two more tests.
In terms of the operator, I'm not 100% sure of the use of the operator. I
would like to see what other CouchDB committers think the of new operator.

Cheers
Garren

On Tue, May 25, 2021 at 2:46 PM hannes <le...@yahoo.de.invalid> wrote:

> Hello couchdb devs,
>
> I would like to add operators $sizeGte and $sizeLte to the mango
> selector language.
>
> Example: It solves the problem of selecting documents with at least 10
> customers and at most 20 customers in the customers array.
>
> I have created a PR here
> - https://github.com/apache/couchdb/pull/3582
>
> Any feedback and help welcome.
>
> best,
> Hannes Klarner.
>