You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/10 08:08:17 UTC

[GitHub] [arrow] heronshoes opened a new issue, #15289: [Ruby] Return other than @table.raw_records when saving Table to csv

heronshoes opened a new issue, #15289:
URL: https://github.com/apache/arrow/issues/15289

   ### Describe the enhancement requested
   
   #### Target method
   
   Arrow::Table#save
   
   #### Proposed feature
   
   Change return value of Table#save when saving to csv files.
   
   Current code returns `@table.raw_records` (Array of row Arrays). When saving a very big Table, it takes long time to display a large Array with interactive execution such as irb or Jupyter.
   
   When we save as 'arrow' or 'arrows', it simply returns 'true'.
   
   Candidates of return value:
   
   - true
   - self
   - size of Table
   
   #### Impact of this request
   
   It will improve the user experience of interactive execution. The return value of #save is rarely used.
   
   #### Reference of this request
   
   https://github.com/apache/arrow/blob/master/ruby/red-arrow/lib/arrow/table-saver.rb#L174-L176
   
   ### Component(s)
   
   Ruby


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou commented on issue #15289: [Ruby] Return other than @table.raw_records when saving Table to csv

Posted by GitBox <gi...@apache.org>.
kou commented on issue #15289:
URL: https://github.com/apache/arrow/issues/15289#issuecomment-1378354788

   Let's use `self`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] heronshoes commented on issue #15289: [Ruby] Return other than @table.raw_records when saving Table to csv

Posted by GitBox <gi...@apache.org>.
heronshoes commented on issue #15289:
URL: https://github.com/apache/arrow/issues/15289#issuecomment-1379623554

   OK. I will create PR. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou closed issue #15289: [Ruby] Return other than @table.raw_records when saving Table to csv

Posted by GitBox <gi...@apache.org>.
kou closed issue #15289: [Ruby] Return other than @table.raw_records when saving Table to csv
URL: https://github.com/apache/arrow/issues/15289


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org