You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/05 00:08:23 UTC

[GitHub] [airflow] josh-fell edited a comment on pull request #21997: [Feature] Updates FTPHook provider to have test_connection

josh-fell edited a comment on pull request #21997:
URL: https://github.com/apache/airflow/pull/21997#issuecomment-1059615713


   It would be a good idea to add a `test_connection_failed` test as well.
   
   Also, it doesn't need to be in this PR but feel free to add if you feel up to it, but adding tests for `test_connection()` for the `FTPSHook` too especially since it inherits from `FTPHook` and overwrites `get_conn()` (which is used in `FTPHook.test_connection()`). WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org