You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/14 04:00:06 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #12362: Reorder Database Migrations

kaxil commented on a change in pull request #12362:
URL: https://github.com/apache/airflow/pull/12362#discussion_r523371507



##########
File path: airflow/migrations/versions/92c57b58940d_add_fab_tables.py
##########
@@ -94,20 +94,20 @@ def upgrade():
     if "ab_user" not in tables:
         op.create_table(
             'ab_user',
-            sa.Column('id', sa.INTEGER(), nullable=False, primary_key=True),
+            sa.Column('id', sa.Integer(), nullable=False, primary_key=True),
             sa.Column('first_name', sa.String(length=64), nullable=False),
             sa.Column('last_name', sa.String(length=64), nullable=False),
             sa.Column('username', sa.String(length=64), nullable=False),
             sa.Column('password', sa.String(length=256), nullable=True),
-            sa.Column('active', sa.BOOLEAN(), nullable=True),
+            sa.Column('active', sa.Boolean(), nullable=True),
             sa.Column('email', sa.String(length=64), nullable=False),
-            sa.Column('last_login', sa.DATETIME(), nullable=True),
-            sa.Column('login_count', sa.INTEGER(), nullable=True),
-            sa.Column('fail_login_count', sa.INTEGER(), nullable=True),
-            sa.Column('created_on', sa.DATETIME(), nullable=True),
-            sa.Column('changed_on', sa.DATETIME(), nullable=True),
-            sa.Column('created_by_fk', sa.INTEGER(), nullable=True),
-            sa.Column('changed_by_fk', sa.INTEGER(), nullable=True),
+            sa.Column('last_login', sa.DateTime(), nullable=True),

Review comment:
       This change was needed for Postgres




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org