You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2018/02/22 07:45:48 UTC
[08/50] [abbrv] hbase git commit: HBASE-2004 TestClientClusterStatus
is flakey
HBASE-2004 TestClientClusterStatus is flakey
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/92bb4db9
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/92bb4db9
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/92bb4db9
Branch: refs/heads/HBASE-19397-branch-2
Commit: 92bb4db9ef367039029017aafe61c51f2c0181f9
Parents: baec532
Author: Michael Stack <st...@apache.org>
Authored: Wed Feb 21 14:52:10 2018 -0800
Committer: Michael Stack <st...@apache.org>
Committed: Wed Feb 21 14:52:10 2018 -0800
----------------------------------------------------------------------
.../hadoop/hbase/TestClientClusterStatus.java | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/92bb4db9/hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterStatus.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterStatus.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterStatus.java
index bfdae8a..392ff6e 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterStatus.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterStatus.java
@@ -37,6 +37,7 @@ import org.apache.hadoop.hbase.regionserver.HRegionServer;
import org.apache.hadoop.hbase.testclassification.MediumTests;
import org.apache.hadoop.hbase.util.JVMClusterUtil.MasterThread;
import org.apache.hadoop.hbase.util.JVMClusterUtil.RegionServerThread;
+import org.apache.hadoop.hbase.util.Threads;
import org.junit.AfterClass;
import org.junit.Assert;
import org.junit.BeforeClass;
@@ -100,13 +101,14 @@ public class TestClientClusterStatus {
@Test
public void testNone() throws Exception {
- ClusterStatus status0
- = new ClusterStatus(ADMIN.getClusterMetrics(EnumSet.allOf(Option.class)));
- ClusterStatus status1
- = new ClusterStatus(ADMIN.getClusterMetrics(EnumSet.noneOf(Option.class)));
- Assert.assertEquals(status0, status1);
- checkPbObjectNotNull(status0);
- checkPbObjectNotNull(status1);
+ ClusterMetrics status0 = ADMIN.getClusterMetrics(EnumSet.allOf(Option.class));
+ ClusterMetrics status1 = ADMIN.getClusterMetrics(EnumSet.noneOf(Option.class));
+ // Do a rough compare. More specific compares can fail because all regions not deployed yet
+ // or more requests than expected.
+ Assert.assertEquals(status0.getLiveServerMetrics().size(),
+ status1.getLiveServerMetrics().size());
+ checkPbObjectNotNull(new ClusterStatus(status0));
+ checkPbObjectNotNull(new ClusterStatus(status1));
}
@Test