You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Attila Szabo <ma...@apache.org> on 2016/12/06 16:44:15 UTC

Review Request 54429: SQOOP-3072: Reenable escaping in ImportTest#testProductWithWhiteSpaceImport for proper execution

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54429/
-----------------------------------------------------------

Review request for Sqoop, Abraham Fine, Boglarka Egyed, Anna Szonyi, Szabolcs Vasas, and Erzsebet Szilagyi.


Bugs: SQOOP-3072
    https://issues.apache.org/jira/browse/SQOOP-3072


Repository: sqoop-trunk


Description
-------

This test is specifically about whitespace supported import scenario.
As the default behaviour in SQOOP-3066 has been reverted back to nonescaped, here we have to enable it.


Diffs
-----

  src/test/org/apache/sqoop/manager/oracle/ImportTest.java cf03cc05 

Diff: https://reviews.apache.org/r/54429/diff/


Testing
-------

ImportTest is running successfully again


Thanks,

Attila Szabo


Re: Review Request 54429: SQOOP-3072: Reenable escaping in ImportTest#testProductWithWhiteSpaceImport for proper execution

Posted by Anna Szonyi <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54429/#review158180
-----------------------------------------------------------


Ship it!




Ship It!

- Anna Szonyi


On Dec. 6, 2016, 4:44 p.m., Attila Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54429/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2016, 4:44 p.m.)
> 
> 
> Review request for Sqoop, Abraham Fine, Boglarka Egyed, Anna Szonyi, Szabolcs Vasas, and Erzsebet Szilagyi.
> 
> 
> Bugs: SQOOP-3072
>     https://issues.apache.org/jira/browse/SQOOP-3072
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> This test is specifically about whitespace supported import scenario.
> As the default behaviour in SQOOP-3066 has been reverted back to nonescaped, here we have to enable it.
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/manager/oracle/ImportTest.java cf03cc05 
> 
> Diff: https://reviews.apache.org/r/54429/diff/
> 
> 
> Testing
> -------
> 
> ImportTest is running successfully again
> 
> 
> Thanks,
> 
> Attila Szabo
> 
>


Re: Review Request 54429: SQOOP-3072: Reenable escaping in ImportTest#testProductWithWhiteSpaceImport for proper execution

Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54429/#review158179
-----------------------------------------------------------


Ship it!




Ship It!

- Szabolcs Vasas


On Dec. 6, 2016, 4:44 p.m., Attila Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54429/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2016, 4:44 p.m.)
> 
> 
> Review request for Sqoop, Abraham Fine, Boglarka Egyed, Anna Szonyi, Szabolcs Vasas, and Erzsebet Szilagyi.
> 
> 
> Bugs: SQOOP-3072
>     https://issues.apache.org/jira/browse/SQOOP-3072
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> This test is specifically about whitespace supported import scenario.
> As the default behaviour in SQOOP-3066 has been reverted back to nonescaped, here we have to enable it.
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/manager/oracle/ImportTest.java cf03cc05 
> 
> Diff: https://reviews.apache.org/r/54429/diff/
> 
> 
> Testing
> -------
> 
> ImportTest is running successfully again
> 
> 
> Thanks,
> 
> Attila Szabo
> 
>