You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Martijn Brinkers (JIRA)" <de...@tapestry.apache.org> on 2008/03/17 10:09:24 UTC
[jira] Created: (TAPESTRY-2267) Eagerload sometimes 'fails' when
multiple modules are used
Eagerload sometimes 'fails' when multiple modules are used
-----------------------------------------------------------
Key: TAPESTRY-2267
URL: https://issues.apache.org/jira/browse/TAPESTRY-2267
Project: Tapestry
Issue Type: Bug
Affects Versions: 5.0.11
Reporter: Martijn Brinkers
I have two modules, module A and module B. Module A has two services SA1 and SA2 both of them are eager loaded. Module B depends on module A so a SubModule annotation is added to Module B. Module B has one service SB1. SB1 is also eager loaded. SB1 needs SA1 for building the service.
If the registry is started and the services are eager loaded using performRegistryStartup() only SB1 and SA2 are eager loaded. SA1 is build when used whereas I would expect it to be eager loaded as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-2267) Services that are dependencies of
other EagerLoad services may not be eagerly loaded
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAPESTRY-2267:
-------------------------------------------
Component/s: tapestry-ioc
Summary: Services that are dependencies of other EagerLoad services may not be eagerly loaded (was: Eagerload sometimes 'fails' when multiple modules are used )
> Services that are dependencies of other EagerLoad services may not be eagerly loaded
> ------------------------------------------------------------------------------------
>
> Key: TAPESTRY-2267
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2267
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-ioc
> Affects Versions: 5.0.11
> Reporter: Martijn Brinkers
> Assignee: Howard M. Lewis Ship
> Attachments: TapestryIOCEagerLoadTest.tar.gz
>
>
> I have two modules, module A and module B. Module A has two services SA1 and SA2 both of them are eager loaded. Module B depends on module A so a SubModule annotation is added to Module B. Module B has one service SB1. SB1 is also eager loaded. SB1 needs SA1 for building the service.
> If the registry is started and the services are eager loaded using performRegistryStartup() only SB1 and SA2 are eager loaded. SA1 is build when used whereas I would expect it to be eager loaded as well.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-2267) Eagerload sometimes 'fails' when
multiple modules are used
Posted by "Martijn Brinkers (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Brinkers updated TAPESTRY-2267:
---------------------------------------
Attachment: TapestryIOCEagerLoadTest.tar.gz
Eclipse test case showing the unexpected eager load behavior.
> Eagerload sometimes 'fails' when multiple modules are used
> -----------------------------------------------------------
>
> Key: TAPESTRY-2267
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2267
> Project: Tapestry
> Issue Type: Bug
> Affects Versions: 5.0.11
> Reporter: Martijn Brinkers
> Attachments: TapestryIOCEagerLoadTest.tar.gz
>
>
> I have two modules, module A and module B. Module A has two services SA1 and SA2 both of them are eager loaded. Module B depends on module A so a SubModule annotation is added to Module B. Module B has one service SB1. SB1 is also eager loaded. SB1 needs SA1 for building the service.
> If the registry is started and the services are eager loaded using performRegistryStartup() only SB1 and SA2 are eager loaded. SA1 is build when used whereas I would expect it to be eager loaded as well.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-2267) Eagerload sometimes 'fails' when
multiple modules are used
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580213#action_12580213 ]
Howard M. Lewis Ship commented on TAPESTRY-2267:
------------------------------------------------
This is occuring because MySecondService is a dependency of MyFirstService. MyFirstService is eager loaded, so MySecondService is virtualized (i.e., a proxy is created) and injected into MyFirstService.
When it comes time to eager load MySecondService, it is being skipped because it is virtual, not defined.
> Eagerload sometimes 'fails' when multiple modules are used
> -----------------------------------------------------------
>
> Key: TAPESTRY-2267
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2267
> Project: Tapestry
> Issue Type: Bug
> Affects Versions: 5.0.11
> Reporter: Martijn Brinkers
> Attachments: TapestryIOCEagerLoadTest.tar.gz
>
>
> I have two modules, module A and module B. Module A has two services SA1 and SA2 both of them are eager loaded. Module B depends on module A so a SubModule annotation is added to Module B. Module B has one service SB1. SB1 is also eager loaded. SB1 needs SA1 for building the service.
> If the registry is started and the services are eager loaded using performRegistryStartup() only SB1 and SA2 are eager loaded. SA1 is build when used whereas I would expect it to be eager loaded as well.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Assigned: (TAPESTRY-2267) Eagerload sometimes 'fails' when
multiple modules are used
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAPESTRY-2267:
----------------------------------------------
Assignee: Howard M. Lewis Ship
> Eagerload sometimes 'fails' when multiple modules are used
> -----------------------------------------------------------
>
> Key: TAPESTRY-2267
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2267
> Project: Tapestry
> Issue Type: Bug
> Affects Versions: 5.0.11
> Reporter: Martijn Brinkers
> Assignee: Howard M. Lewis Ship
> Attachments: TapestryIOCEagerLoadTest.tar.gz
>
>
> I have two modules, module A and module B. Module A has two services SA1 and SA2 both of them are eager loaded. Module B depends on module A so a SubModule annotation is added to Module B. Module B has one service SB1. SB1 is also eager loaded. SB1 needs SA1 for building the service.
> If the registry is started and the services are eager loaded using performRegistryStartup() only SB1 and SA2 are eager loaded. SA1 is build when used whereas I would expect it to be eager loaded as well.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAPESTRY-2267) Services that are dependencies of
other EagerLoad services may not be eagerly loaded
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAPESTRY-2267.
------------------------------------------
Resolution: Fixed
Fix Version/s: 5.0.12
Changed the logic to collect all eager load proxies from all modules before eagerly loading any of them. It used to be per-module which could lead to the unexpected results.
> Services that are dependencies of other EagerLoad services may not be eagerly loaded
> ------------------------------------------------------------------------------------
>
> Key: TAPESTRY-2267
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2267
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-ioc
> Affects Versions: 5.0.11
> Reporter: Martijn Brinkers
> Assignee: Howard M. Lewis Ship
> Fix For: 5.0.12
>
> Attachments: TapestryIOCEagerLoadTest.tar.gz
>
>
> I have two modules, module A and module B. Module A has two services SA1 and SA2 both of them are eager loaded. Module B depends on module A so a SubModule annotation is added to Module B. Module B has one service SB1. SB1 is also eager loaded. SB1 needs SA1 for building the service.
> If the registry is started and the services are eager loaded using performRegistryStartup() only SB1 and SA2 are eager loaded. SA1 is build when used whereas I would expect it to be eager loaded as well.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org