You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by d2r <gi...@git.apache.org> on 2014/09/03 17:07:57 UTC
[GitHub] incubator-storm pull request: [STORM-485] use separate logback con...
GitHub user d2r opened a pull request:
https://github.com/apache/incubator-storm/pull/248
[STORM-485] use separate logback config for workers
Adds a new logback configuration file for workers.
It is the same as the current cluster.xml, but without metrics and access "appenders."
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/d2r/incubator-storm STORM-485-separate-worker-logback
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/248.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #248
----
commit af61cca75c6215d5a0db2d6fb338deca03e55095
Author: Derek Dagit <de...@yahoo-inc.com>
Date: 2014-09-03T15:05:25Z
use separate logback config for workers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-485] use separate logback con...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/incubator-storm/pull/248#issuecomment-54514303
@d2r I think following need to be added to storm-dist/binary/src/main/assembly/binary.xml
<file>
<source>${project.basedir}/../../logback/worker.xml</source>
<outputDirectory>/logback</outputDirectory>
</file>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-485] use separate logback con...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/248#issuecomment-54503838
+1 looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-485] use separate logback con...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/incubator-storm/pull/248#issuecomment-54547850
+1 looks good. thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-485] use separate logback con...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/248#issuecomment-54516568
> @d2r I think following need to be added to storm-dist/binary/src/main/assembly/binary.xml
@harshach Good catch. I did a grep looking for cluster.xml to see if there was anywhere else I might need to call out the new file. I did not find any additional matches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---