You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Werner Mueller (JIRA)" <ji...@apache.org> on 2007/11/13 18:34:42 UTC
[jira] Created: (VFS-180) Support HTTPS / SSL for Webdav
Support HTTPS / SSL for Webdav
------------------------------
Key: VFS-180
URL: https://issues.apache.org/jira/browse/VFS-180
Project: Commons VFS
Issue Type: New Feature
Affects Versions: 1.0, 1.1
Reporter: Werner Mueller
The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
regards
werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-180) Support HTTPS / SSL for Webdav
Posted by "James William Dumay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688556#action_12688556 ]
James William Dumay commented on VFS-180:
-----------------------------------------
Sorry about that Ralph ill clean this patch up and resubmit.
> Support HTTPS / SSL for Webdav
> ------------------------------
>
> Key: VFS-180
> URL: https://issues.apache.org/jira/browse/VFS-180
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.0, 1.1
> Reporter: Werner Mueller
> Attachments: VFS-180.patch, VFS-180.patch
>
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-180) Support HTTPS / SSL for Webdav
Posted by "Joerg Schaible (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542386 ]
Joerg Schaible commented on VFS-180:
------------------------------------
> in the end i would like to point to the webdav/ssl support feature :)
Same here. When slide was retired the webdav implementation of jackrabbit was explicitly mentioned as replacement. So I thought it would be a little more than just some interfaces. However, I did not have a look yet, but wanted to prevent anyone from striking a dead horse.
Note, that slide was also retired because no developer was there to fix security issues and therefore the retirement was the better alternative. Although I really like to have the webdav support in VFS, as a release manager it would scare me to include it into a final VFS release with open security issues :-/
> Support HTTPS / SSL for Webdav
> ------------------------------
>
> Key: VFS-180
> URL: https://issues.apache.org/jira/browse/VFS-180
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.0, 1.1
> Reporter: Werner Mueller
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-180) Support HTTPS / SSL for Webdav
Posted by "Joerg Schaible (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542351 ]
Joerg Schaible commented on VFS-180:
------------------------------------
Since Slide has officially been retired, you may also have a short look at the alternative jackrabbit implementation as replacement.
> Support HTTPS / SSL for Webdav
> ------------------------------
>
> Key: VFS-180
> URL: https://issues.apache.org/jira/browse/VFS-180
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.0, 1.1
> Reporter: Werner Mueller
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-180) Support HTTPS / SSL for Webdav
Posted by "Jason Harrop (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586213#action_12586213 ]
Jason Harrop commented on VFS-180:
----------------------------------
I've created a project on sourceforge to maintain/enhance the webdav client component of slide.
See https://sourceforge.net/projects/webdavclient4j
> Support HTTPS / SSL for Webdav
> ------------------------------
>
> Key: VFS-180
> URL: https://issues.apache.org/jira/browse/VFS-180
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.0, 1.1
> Reporter: Werner Mueller
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-180) Support HTTPS / SSL for Webdav
Posted by "Werner Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542364 ]
Werner Mueller commented on VFS-180:
------------------------------------
maybe i've read the docs wrong. but the jackrabbit implementation is based on rmi? and the jackrabbit webdav client seems to exist mostly of interfaces. it seems to add something to httpclient. but i could not find any docs or examples. no docs no features - to be a bit polemic
indeed slide is retired but quite some tools rely on slide webdavlib. so that code maybe worth saving. anyhow vfs may be able to use wither slide or jackrabbit.
i simply dont know anything about slide/jackrabbit/webdav plans at apache.
in the end i would like to point to the webdav/ssl support feature :)
> Support HTTPS / SSL for Webdav
> ------------------------------
>
> Key: VFS-180
> URL: https://issues.apache.org/jira/browse/VFS-180
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.0, 1.1
> Reporter: Werner Mueller
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-180) Support HTTPS / SSL for Webdav
Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542203 ]
Matt Benson commented on VFS-180:
---------------------------------
I'll be needing this in the near future and might be able to spare some cycles to work on it.
> Support HTTPS / SSL for Webdav
> ------------------------------
>
> Key: VFS-180
> URL: https://issues.apache.org/jira/browse/VFS-180
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.0, 1.1
> Reporter: Werner Mueller
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (VFS-180) Support HTTPS / SSL for Webdav
Posted by "James William Dumay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James William Dumay updated VFS-180:
------------------------------------
Attachment: VFS-180.patch
I uploaded the wrong patch before - here is a complete https implementation. Not sure how well this works right now but its a good start.
> Support HTTPS / SSL for Webdav
> ------------------------------
>
> Key: VFS-180
> URL: https://issues.apache.org/jira/browse/VFS-180
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.0, 1.1
> Reporter: Werner Mueller
> Attachments: VFS-180.patch, VFS-180.patch
>
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (VFS-180) Support HTTPS / SSL for Webdav
Posted by "James William Dumay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James William Dumay updated VFS-180:
------------------------------------
Attachment: VFS-180.patch
Sorry, I got confused on the way this should be done. Ive tested this against Apache 2.0.52 and it works fine.
> Support HTTPS / SSL for Webdav
> ------------------------------
>
> Key: VFS-180
> URL: https://issues.apache.org/jira/browse/VFS-180
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.0, 1.1
> Reporter: Werner Mueller
> Attachments: VFS-180.patch, VFS-180.patch, VFS-180.patch
>
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-180) Support HTTPS / SSL for Webdav
Posted by "Ralph Goers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688536#action_12688536 ]
Ralph Goers commented on VFS-180:
---------------------------------
Why are all the changes required? I would have thought it could be done simpler by changing the hardcoded "http" in WebdavFileProvider to getScheme() as you did and then defining a WebdavFileProvider with
public class WebdavsFileProvider extends WebdavFileProvider
{
public WebdavsFileProvider()
{
super();
setFileNameParser(WebdavsFileNameParser.getInstance());
}
protected String getScheme()
{
return "https";
}
}
Then define WebdavsFileNameParser to be pretty much like WebdavFileNameParser but have it extend HttpsFileNameParser. Is there something I am missing?
These should go into a webdavs package, not be comingled in the webdav package.
> Support HTTPS / SSL for Webdav
> ------------------------------
>
> Key: VFS-180
> URL: https://issues.apache.org/jira/browse/VFS-180
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.0, 1.1
> Reporter: Werner Mueller
> Attachments: VFS-180.patch, VFS-180.patch
>
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-180) Support HTTPS / SSL for Webdav
Posted by "Werner Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542405 ]
Werner Mueller commented on VFS-180:
------------------------------------
well the slide retirement was a good decision. painfull but in the end the situatiion will improve.
i've seen the latest slide security issue (lock eploit?) was fixed in trunk and a retirement branch.
in any case slide should get a fresh start somewhere. maybe httpclient-webdav. so vfs could depend on that.
well these things should be discussed somewhere else :)
i would agree vfs 1.1 should no longer use the current slide-2.1 lib.
> Support HTTPS / SSL for Webdav
> ------------------------------
>
> Key: VFS-180
> URL: https://issues.apache.org/jira/browse/VFS-180
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.0, 1.1
> Reporter: Werner Mueller
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-180) Support HTTPS / SSL for Webdav
Posted by "Ralph Goers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688533#action_12688533 ]
Ralph Goers commented on VFS-180:
---------------------------------
I tried applying the patch and then running "mvn clean -P webdav test -Dtest=WebdavProviderTestCase". It fails with a StackOverflow.
java.lang.StackOverflowError
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.getProperty(WebdavFileObject.java:402)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.isDirectory(WebdavFileObject.java:382)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.doGetType(WebdavFileObject.java:112)
at org.apache.commons.vfs.provider.AbstractFileObject.getType(AbstractFileObject.java:441)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.urlString(WebdavFileObject.java:504)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.urlString(WebdavFileObject.java:484)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.getProperties(WebdavFileObject.java:438)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.getProperties(WebdavFileObject.java:417)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.getProperty(WebdavFileObject.java:410)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.getProperty(WebdavFileObject.java:402)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.isDirectory(WebdavFileObject.java:382)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.doGetType(WebdavFileObject.java:112)
at org.apache.commons.vfs.provider.AbstractFileObject.getType(AbstractFileObject.java:441)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.urlString(WebdavFileObject.java:504)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.urlString(WebdavFileObject.java:484)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.getProperties(WebdavFileObject.java:438)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.getProperties(WebdavFileObject.java:417)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.getProperty(WebdavFileObject.java:410)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.getProperty(WebdavFileObject.java:402)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.isDirectory(WebdavFileObject.java:382)
at org.apache.commons.vfs.provider.webdav.WebdavFileObject.doGetType(WebdavFileObject.java:112)
at org.apache.commons.vfs.provider.AbstractFileObject.getType(AbstractFileObject.java:441)
> Support HTTPS / SSL for Webdav
> ------------------------------
>
> Key: VFS-180
> URL: https://issues.apache.org/jira/browse/VFS-180
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.0, 1.1
> Reporter: Werner Mueller
> Attachments: VFS-180.patch, VFS-180.patch
>
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (VFS-180) Support HTTPS / SSL for Webdav
Posted by "James William Dumay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James William Dumay updated VFS-180:
------------------------------------
Attachment: VFS-180.patch
Patch provides a https enabled Webdav(s)FileProvider. Seems to work just fine with my Apache httpd webdav repositories.
> Support HTTPS / SSL for Webdav
> ------------------------------
>
> Key: VFS-180
> URL: https://issues.apache.org/jira/browse/VFS-180
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.0, 1.1
> Reporter: Werner Mueller
> Attachments: VFS-180.patch
>
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be possible to add https support to vfs too. currently the webdav provider creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.