You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/09 05:23:12 UTC
[GitHub] [incubator-doris] morrySnow opened a new pull request, #9460: [style]format fe code with some check rules
morrySnow opened a new pull request, #9460:
URL: https://github.com/apache/incubator-doris/pull/9460
# Proposed changes
Issue Number: close #9403
set below rules' severity to error and format code according check info.
a. Merge conflicts unresolved
b. Avoid using corresponding octal or Unicode escape
c. Avoid Escaped Unicode Characters
d. No Line Wrap
e. Package Name
f. Type Name
g. Annotation Location
h. Interface Type Parameter
i. CatchParameterName
j. Pattern Variable Name
k. Record Component Name
l. Record Type Parameter Name
m. Method Type Parameter Name
n. Redundant Import
o. Custom Import Order
p. Unused Imports
q. Avoid Star Import
r. tab character in file
s. Newline At End Of File
t. Trailing whitespace found
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9460: [style]format fe code with some check rules
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9460:
URL: https://github.com/apache/incubator-doris/pull/9460#issuecomment-1124916283
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9460: [style]format fe code with some check rules
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9460:
URL: https://github.com/apache/incubator-doris/pull/9460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on pull request #9460: [style]format fe code with some check rules
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #9460:
URL: https://github.com/apache/incubator-doris/pull/9460#issuecomment-1123400741
> In fact, the following configuration is enough. `reviewdog` is not a necessity. Because when met wrong checkstyle, `mvn checkstyle:check` also can cause the ut failed.
>
> ```
> ---
> name: FE Code Style Checker
> on:
> pull_request:
> jobs:
> java-checkstyle:
> name: "CheckStyle"
> runs-on: ubuntu-latest
> steps:
> - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
> uses: actions/checkout@v2
> with:
> persist-credentials: false
> submodules: recursive
> - name: "Run java checkstyle"
> run:
> cd fe && mvn checkstyle:check
>
> ```
The final status is setting all check style rules' severity to 'error'. Currently, we have too many original code that violate check style rules. We need to fix all warnings caused by original codes and set Checker's severity to 'error' before we use `mvn checkstyle:check` instead of review dog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on pull request #9460: [style]format fe code with some check rules
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #9460:
URL: https://github.com/apache/incubator-doris/pull/9460#issuecomment-1123374228
> hi @morrySnow, i think we can improve the check action by using `mvn checkstyle:check` directly like apache seatunnel.
>
> it seems the following action still has probem which will cause the ut fail. https://github.com/apache/incubator-doris/blob/master/.github/workflows/checkstyle.yaml
could `mvn checkstyle:check` can combined with reviewdog?
what do you mean about `ut fail`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on pull request #9460: [style]format fe code with some check rules
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #9460:
URL: https://github.com/apache/incubator-doris/pull/9460#issuecomment-1120785395
> hi @morrySnow, the `FE Code Formatter` still failed, how about use `mvn checkstyle:check` directly?
>
> https://github.com/apache/incubator-seatunnel/tree/dev/.github/workflows/backend.yml#L104
>
> ```
> Raw Output:
> /github/workspace/./fe/fe-core/src/test/java/org/apache/doris/planner/OlapScanNodeTest.java:40:1: warning: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck)
> Error: reviewdog: Too many results (annotations) in diff.
> You may miss some annotations due to GitHub limitation for annotation created by logging command.
> Please check GitHub Actions log console to see all results.
> ```
Just like i comment above. I has do `mvn checkstyle:check` locally before commit pr. I checked the error list. Currently, Checker failed caused by some rules that patch do not care about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] leo65535 commented on pull request #9460: [style]format fe code with some check rules
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #9460:
URL: https://github.com/apache/incubator-doris/pull/9460#issuecomment-1120744260
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] leo65535 commented on pull request #9460: [style]format fe code with some check rules
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #9460:
URL: https://github.com/apache/incubator-doris/pull/9460#issuecomment-1120748395
hi @morrySnow, the `FE Code Formatter` still failed, how about use `mvn checkstyle:check` directly?
https://github.com/apache/incubator-seatunnel/tree/dev/.github/workflows/backend.yml#L104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on pull request #9460: [style]format fe code with some check rules
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #9460:
URL: https://github.com/apache/incubator-doris/pull/9460#issuecomment-1120698015
all fe check style error is not related to the rules this patch care about
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] leo65535 commented on pull request #9460: [style]format fe code with some check rules
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #9460:
URL: https://github.com/apache/incubator-doris/pull/9460#issuecomment-1123315095
hi @morrySnow, i think we can improve the check action by using `mvn checkstyle:check` directly like apache seatunnel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] leo65535 commented on pull request #9460: [style]format fe code with some check rules
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #9460:
URL: https://github.com/apache/incubator-doris/pull/9460#issuecomment-1123387420
In fact, the following configuration is enough. `reviewdog` is not a necessity. Because when met wrong checkstyle, `mvn checkstyle:check` also can cause the ut failed.
```
---
name: FE Code Style Checker
on:
pull_request:
jobs:
java-checkstyle:
name: "CheckStyle"
runs-on: ubuntu-latest
steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v2
with:
persist-credentials: false
submodules: recursive
- name: "Run java checkstyle"
run:
cd fe && mvn checkstyle:check
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9460: [style]format fe code with some check rules
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9460:
URL: https://github.com/apache/incubator-doris/pull/9460#issuecomment-1120791833
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org