You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/29 16:13:40 UTC
[GitHub] [tvm] ashutosh-arm opened a new pull request #10817: [CMSIS-NN] Aligned scale computation with TFLM to fix numerical mismatch
ashutosh-arm opened a new pull request #10817:
URL: https://github.com/apache/tvm/pull/10817
This PR fixes numerical mismatch in Conv2D layers by
aligning order of output scale computation
with TFLM. Correct output scale is needed
to calculate quantization parameters needed
by CMSIS-NN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on a change in pull request #10817: [CMSIS-NN] Aligned scale computation with TFLM to fix numerical mismatch
Posted by GitBox <gi...@apache.org>.
Mousius commented on a change in pull request #10817:
URL: https://github.com/apache/tvm/pull/10817#discussion_r838295980
##########
File path: tests/python/contrib/test_cmsisnn/test_conv2d.py
##########
@@ -304,6 +304,94 @@ def test_conv2d_asymmetric_padding_int8(
)
+# This test expects assertion as the output should mismatch between TVM and CMSIS-NN
Review comment:
Could this assert that it matches the expected output? Similar to how the NPU tests check that they are consistent with TFLite?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ashutosh-arm commented on pull request #10817: [CMSIS-NN] Aligned scale computation with TFLM to fix numerical mismatch
Posted by GitBox <gi...@apache.org>.
ashutosh-arm commented on pull request #10817:
URL: https://github.com/apache/tvm/pull/10817#issuecomment-1082792258
cc: @manupa-arm @Mousius @grant-arm for code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ashutosh-arm commented on a change in pull request #10817: [CMSIS-NN] Aligned scale computation with TFLM to fix numerical mismatch
Posted by GitBox <gi...@apache.org>.
ashutosh-arm commented on a change in pull request #10817:
URL: https://github.com/apache/tvm/pull/10817#discussion_r838302483
##########
File path: tests/python/contrib/test_cmsisnn/test_conv2d.py
##########
@@ -304,6 +304,94 @@ def test_conv2d_asymmetric_padding_int8(
)
+# This test expects assertion as the output should mismatch between TVM and CMSIS-NN
Review comment:
Yes, we could compare against TFLite output. So far all the CMSIS-NN tests compare against TVM output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ashutosh-arm commented on pull request #10817: [CMSIS-NN] Aligned scale computation with TFLM to fix numerical mismatch
Posted by GitBox <gi...@apache.org>.
ashutosh-arm commented on pull request #10817:
URL: https://github.com/apache/tvm/pull/10817#issuecomment-1086119551
@Mousius I have added a TFLite test. PTAL when you have time. As discussed offline, we can move this test to tvm/testing area in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org