[GitHub] [iceberg] rdblue commented on a diff in pull request #5287: Python: First version of the rest catalog

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5287:
URL: https://github.com/apache/iceberg/pull/5287#discussion_r922528602


##########
core/src/main/java/org/apache/iceberg/SchemaParser.java:
##########
@@ -254,8 +254,8 @@ private static Types.MapType mapFromJson(JsonNode json) {
   }
 
   public static Schema fromJson(JsonNode json) {
-    Type type  = typeFromJson(json);
-    Preconditions.checkArgument(type.isNestedType() && type.asNestedType().isStructType(),
+    Type type = typeFromJson(json);
+    Preconditions.checkArgument(type != null && type.isNestedType() && type.asNestedType().isStructType(),

Review Comment:
   Can you open a separate PR for Java fixes? This looks good to me, but we try not to mix changes like this into other PRs to avoid commit conflicts when cherry picking to maintain branches.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org