You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/10/22 14:49:22 UTC

[GitHub] [libcloud] dpeschman edited a comment on pull request #1557: OpenStack authentication token cache

dpeschman edited a comment on pull request #1557:
URL: https://github.com/apache/libcloud/pull/1557#issuecomment-949701083


   Thanks @Kami .  Reviewing the ICLA now.  
   
   One thing I notice looking over the code once more - [this change](https://github.com/apache/libcloud/pull/1557/files#diff-27e709eb9d4122cf8cdab8e8e756cd20220545b39e6fca6ab7af8517470b62a5L614) (need to expand openstack_identity.py) to the exception message seems like it might break backwards compatibility.  The rest of the change is backwards compatible, and I did not need this exception text changed for any particular reason, was just a grammar fix.  So I can revert that part if it is desirable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org