You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "James E. King, III (JIRA)" <ji...@apache.org> on 2017/04/04 20:29:41 UTC

[jira] [Commented] (THRIFT-4166) Recent fix to remove boost::lexical_cast usage broke VS2010

    [ https://issues.apache.org/jira/browse/THRIFT-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955752#comment-15955752 ] 

James E. King, III commented on THRIFT-4166:
--------------------------------------------

Adding MSVC2010 to appveyor is not as easy as it sounds:

# Appveyor only has 32-bit MSVC2010 support installed
# Appveyor has no MSVC2010 boost libraries

> Recent fix to remove boost::lexical_cast usage broke VS2010
> -----------------------------------------------------------
>
>                 Key: THRIFT-4166
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4166
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.11.0
>         Environment: VS2010
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>            Priority: Minor
>
> Removal of boost::lexical_cast and replaced with code that calls std::log10(2).  std::log10(2) is ambiguous to VS2010.
> # Fix build breakage
> # add VS2010 build job to Appveyor to prevent future regression.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)