[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #10759: Add selectList, fromClause definitions for Oracle Select

[GitBox <gi...@apache.org>]

wgy8283335 commented on a change in pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#discussion_r652260311



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/BaseRule.g4
##########
@@ -731,3 +735,39 @@ unitName
 procedureName
     : identifier
     ;
+
+validTimeColumn
+    : columnName
+    ;
+
+attrDim
+    : identifier
+    ;
+
+hierarchyName
+    : (owner DOT_)? name
+    ;
+
+analyticViewName
+    : (owner DOT_)? name
+    ;
+
+samplePercent
+    : numberLiterals
+    ;
+
+seedValue
+    : numberLiterals
+    ;
+
+condition
+    : expr
+    ;
+
+variableName
+    : identifier | STRING_
+    ;
+
+externalTableDataProps

Review comment:
       It's better to move the rule to DDLStatement. And rename the rule and copy the rule in DMLStatement.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org