[PATCH 55428] add more mod_autoindex tests

[Sven Dowideit <Sv...@home.org.au>]

I'd like to add more tests for different configurations to give my
re-factoring of mod_autoindex some chance of being correct.

To that end, I ask if this new Apache::Test (autoindex3.t) can be merged.

It uses the Perl __DATA__ section to contain the .htaccess conf t be
tested, and the expected output.

Cheers
Sven

PS - is there someone I can talk to about Apache::Test development?

Re: [PATCH 55428] add more mod_autoindex tests

[Stefan Fritsch <sf...@sfritsch.de>]

Am Freitag, 16. August 2013, 11:38:39 schrieb Sven Dowideit:
> I'd like to add more tests for different configurations to give my
> re-factoring of mod_autoindex some chance of being correct.
> 
> To that end, I ask if this new Apache::Test (autoindex3.t) can be
> merged.
> 
> It uses the Perl __DATA__ section to contain the .htaccess conf t be
> tested, and the expected output.

I am sure the test is useful if you want to refactor mod_autoindex and 
know that the output should not change between before and after your 
changes. However, as a general test, I am not sure that a byte for 
byte comparision of output against some expected output is a good 
idea. It will cause test failures if mod_autoindex's output changes in 
any way, not just if some functionality is broken. Therefore I would 
rather not commit it to the perl-framework repository. However, I am 
interested in the opinions of other committers.

> PS - is there someone I can talk to about Apache::Test development?

Is this developed as part of mod_perl? Then the mod_perl lists would 
be appropriate. But I am not sure.