You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/01/21 01:53:54 UTC
[GitHub] [guacamole-server] mike-jumper opened a new pull request #250:
GUACAMOLE-934: Add support for the Play Sound PDU.
mike-jumper opened a new pull request #250: GUACAMOLE-934: Add support for the Play Sound PDU.
URL: https://github.com/apache/guacamole-server/pull/250
This change adds support for the [Play Sound PDU](https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpbcgr/e9fb1ecb-191c-45ca-84a0-b7db6366e467), which requests that the client beep at a given frequency and for a given duration.
As written, this support limits the maximum duration of each requested beep to half a second, despite RDP technically supporting beeps up to 50 days long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] jmuehlner commented on issue #250:
GUACAMOLE-934: Add support for the Play Sound PDU.
Posted by GitBox <gi...@apache.org>.
jmuehlner commented on issue #250: GUACAMOLE-934: Add support for the Play Sound PDU.
URL: https://github.com/apache/guacamole-server/pull/250#issuecomment-577024013
I think any users will appreciate that we don't play 50 day long beeps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] mike-jumper commented on issue #250:
GUACAMOLE-934: Add support for the Play Sound PDU.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on issue #250: GUACAMOLE-934: Add support for the Play Sound PDU.
URL: https://github.com/apache/guacamole-server/pull/250#issuecomment-576530860
Hold on, there seems to be something off in my square wave math.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] mike-jumper commented on issue #250:
GUACAMOLE-934: Add support for the Play Sound PDU.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on issue #250: GUACAMOLE-934: Add support for the Play Sound PDU.
URL: https://github.com/apache/guacamole-server/pull/250#issuecomment-576565733
OK - my calculations were indeed wrong, suffering from rounding error in the width of the cycle of the square wave. Correcting for this, tones were correct but suffered from severe aliasing distortion at all but high sample rates, so I've switched to a triangle wave.
Things should now be correct and distortion should be minimal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] jmuehlner merged pull request #250:
GUACAMOLE-934: Add support for the Play Sound PDU.
Posted by GitBox <gi...@apache.org>.
jmuehlner merged pull request #250: GUACAMOLE-934: Add support for the Play Sound PDU.
URL: https://github.com/apache/guacamole-server/pull/250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services