[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4617: Add kind "unknown" to fallback activations

[GitBox <gi...@apache.org>]

sven-lange-last commented on a change in pull request #4617: Add kind "unknown" to fallback activations
URL: https://github.com/apache/openwhisk/pull/4617#discussion_r323119026
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
 ##########
 @@ -263,7 +263,10 @@ class InvokerReactive(
                 }
 
                 val context = UserContext(msg.user)
-                val activation = generateFallbackActivation(msg, response)
+                val activation = generateFallbackActivation(
+                  msg,
+                  response,
+                  Parameters(WhiskActivation.kindAnnotation, JsString(Exec.UNKNOWN)))
 
 Review comment:
   @rabbah although I originally suggested the approach to extend the signature of `generateFallbackActivation()` to allow for passing additional annotations in #4615, I now agree with your assessment.
   
   `generateFallbackActivation()` is used exactly two times within the same compilation unit in close proximity to its definition. So it's fine to add the `kind = unknown` annotation directly within `generateFallbackActivation()`.
   
   @jiangpengcheng I suggest to add a comment to `generateFallbackActivation()` why the `kind = unknown` annotation is set, i.e. in order to support user metrics because the metrics record requires a kind.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services