[GitHub] [beam] boyuanzz commented on a change in pull request #11199: [BEAM-9562][WIP] Update Timer encoding with respect of dynamic timers

[GitBox <gi...@apache.org>]

boyuanzz commented on a change in pull request #11199: [BEAM-9562][WIP] Update Timer encoding with respect of dynamic timers
URL: https://github.com/apache/beam/pull/11199#discussion_r401851561
 
 

 ##########
 File path: sdks/python/apache_beam/coders/coder_impl.py
 ##########
 @@ -629,22 +629,56 @@ def estimate_size(self, unused_value, nested=False):
 
 class TimerCoderImpl(StreamCoderImpl):
   """For internal use only; no backwards-compatibility guarantees."""
-  def __init__(self, payload_coder_impl):
+  def __init__(self, key_coder_impl, window_coder_impl, tag_coder_impl):
 
 Review comment:
   Yes it should be as long as we agree on that the tag should be `string`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services