You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/04/27 01:36:13 UTC

[GitHub] [iceberg] zhangjun0x01 opened a new pull request #2522: Core : snatshot read with schema change

zhangjun0x01 opened a new pull request #2522:
URL: https://github.com/apache/iceberg/pull/2522


   When we modify the schema of the iceberg table and do  a time travel query by specifying the `snapshot-id`, the query result shows the current latest schema, but we want the  schema of query result to be corresponding with the snapshot.
   
   I add a `schema-id` to the snapshot in metadata , when we query by `snapshot-id` , we get the schema by the `schema-id` in the snapshot
   
   @rdblue  @aokolnychyi @openinx could you help me review it ? thanks.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] zhangjun0x01 commented on pull request #2522: Core : snatshot read with schema change

Posted by GitBox <gi...@apache.org>.
zhangjun0x01 commented on pull request #2522:
URL: https://github.com/apache/iceberg/pull/2522#issuecomment-827265790


   I found that this pr seems to be  duplicate. I found other similar pr (https://github.com/apache/iceberg/pull/2275 ,https://github.com/apache/iceberg/pull/2096). I will close this pr, but I think we should add test cases for different computing engines (spark, flink, hive) so that they can works correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] zhangjun0x01 closed pull request #2522: Core : snatshot read with schema change

Posted by GitBox <gi...@apache.org>.
zhangjun0x01 closed pull request #2522:
URL: https://github.com/apache/iceberg/pull/2522


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org