You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/10 09:43:39 UTC
[GitHub] [incubator-nuttx] cisvanmierlo opened a new pull request #4508: s32k1xx: added way to get the reset cause in a proc fs
cisvanmierlo opened a new pull request #4508:
URL: https://github.com/apache/incubator-nuttx/pull/4508
## Summary
Added an optional proc fs to get the reset cause, which can be used in the application to act on.
## Impact
minimal, only added the optional proc fs to current system.
## Testing
Tested on RDDRONE-BMS772, it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4508: s32k1xx: added way to get the reset cause in a proc fs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4508:
URL: https://github.com/apache/incubator-nuttx/pull/4508#issuecomment-918775955
@Ouss4 let's merge it first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4508: s32k1xx: added way to get the reset cause in a proc fs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4508:
URL: https://github.com/apache/incubator-nuttx/pull/4508#issuecomment-917603860
@gustavonihei @Ouss4 since the reset cause is very important information, should we standardize all possible cause and require SoC convert the private definition to the standard one? Another question is what's the best method to expose this crucial info to userspace monitor tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4508: s32k1xx: added way to get the reset cause in a proc fs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #4508:
URL: https://github.com/apache/incubator-nuttx/pull/4508#issuecomment-917603860
@gustavonihei @Ouss4 since the reset cause is very important information, should we standardize all possible cause and require SoC convert the private definition to the standard one? Another question is what's the best method to expose this crucial info to userspace monitor tool(procfs .v.s. boardctl).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cisvanmierlo commented on pull request #4508: s32k1xx: added way to get the reset cause in a proc fs
Posted by GitBox <gi...@apache.org>.
cisvanmierlo commented on pull request #4508:
URL: https://github.com/apache/incubator-nuttx/pull/4508#issuecomment-917916553
Hi, this is for the S32K1xx only and this is needed for the BMS application. We could always adjust it when there is a generic interface for the reset cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4508: s32k1xx: added way to get the reset cause in a proc fs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4508:
URL: https://github.com/apache/incubator-nuttx/pull/4508#issuecomment-917661701
> > since the reset cause is very important information, should we standardize all possible cause and require SoC convert the private definition to the standard one?
>
> We can have a subset of the rest causes that are common, but we'll still have a few that are specific to a particular SoC. How would we handle that? I guess we can do something as easy as considering the values above the common set max to be chip specific.
>
Yes, we can define the common cause, and reserve a range for SoC specific cause, just like IOCTL.
> As for the best way to get this info, I personally don't know which one is best between procfs and boardctl, they actually both tend to go beyond their scope (see #1132 for instance.)
> We already use broadctl for stuff like uniqueid and actually reseting the board, the reset cause seems to be similar to these, is there any reason to use procfs here?
procfs is good for the interactive usage, but hard to parse/use by the tool and also increase the noticeable size for tiny device.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4508: s32k1xx: added way to get the reset cause in a proc fs
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #4508:
URL: https://github.com/apache/incubator-nuttx/pull/4508#issuecomment-917655685
> since the reset cause is very important information, should we standardize all possible cause and require SoC convert the private definition to the standard one?
We can have a subset of the rest causes that are common, but we'll still have a few that are specific to a particular SoC. How would we handle that? I guess we can do something as easy as considering the values above the common set max to be chip specific.
As for the best way to get this info, I personally don't know which one is best between procfs and boardctl, they actually both tend to go beyond their scope (see https://github.com/apache/incubator-nuttx/issues/1132 for instance.)
We already use broadctl for stuff like uniqueid and actually reseting the board, the reset cause seems to be similar to these, is there any reason to use procfs here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #4508: s32k1xx: added way to get the reset cause in a proc fs
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #4508:
URL: https://github.com/apache/incubator-nuttx/pull/4508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org