You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2022/03/09 22:35:12 UTC

[GitHub] [cxf] reta opened a new pull request #922: CXF-8673: Bump httpasyncclient version to 4.1.5

reta opened a new pull request #922:
URL: https://github.com/apache/cxf/pull/922


   Bump httpasyncclient version to 4.1.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cxf] reta merged pull request #922: CXF-8673: Bump httpasyncclient version to 4.1.5

Posted by GitBox <gi...@apache.org>.
reta merged pull request #922:
URL: https://github.com/apache/cxf/pull/922


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cxf] ffang commented on a change in pull request #922: CXF-8673: Bump httpasyncclient version to 4.1.5

Posted by GitBox <gi...@apache.org>.
ffang commented on a change in pull request #922:
URL: https://github.com/apache/cxf/pull/922#discussion_r825138760



##########
File path: rt/transports/http-hc/src/main/java/org/apache/cxf/transport/http/asyncclient/AsyncHTTPConduit.java
##########
@@ -561,7 +561,10 @@ protected void verifySession(final HttpHost host,
                                     setSSLSession(sslsession);
                                 }
                             });
+                    // See please https://issues.apache.org/jira/browse/HTTPASYNC-168, the attribute names
+                    // are case-sensitive.
                     ctx.setAttribute("http.iosession-factory-registry", regBuilder.build());

Review comment:
       Ah, that's it, thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cxf] reta commented on a change in pull request #922: CXF-8673: Bump httpasyncclient version to 4.1.5

Posted by GitBox <gi...@apache.org>.
reta commented on a change in pull request #922:
URL: https://github.com/apache/cxf/pull/922#discussion_r823256057



##########
File path: rt/transports/http-hc/src/main/java/org/apache/cxf/transport/http/asyncclient/AsyncHTTPConduit.java
##########
@@ -561,7 +561,10 @@ protected void verifySession(final HttpHost host,
                                     setSSLSession(sslsession);
                                 }
                             });
+                    // See please https://issues.apache.org/jira/browse/HTTPASYNC-168, the attribute names
+                    // are case-sensitive.
                     ctx.setAttribute("http.iosession-factory-registry", regBuilder.build());

Review comment:
       @ffang may I ask you to take a look please? thank you!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org