You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2023/02/28 13:51:04 UTC

[GitHub] [incubator-celeborn] waitinfuture opened a new pull request, #1287: [CELEBORN-348] Support fetchTime in load-aware slots assignment strategy

waitinfuture opened a new pull request, #1287:
URL: https://github.com/apache/incubator-celeborn/pull/1287

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   Currently load-aware slots assignment strategy only considers flush time, but flush time might not correctly
   reflects disk performance because we do not flush to disk. It's more reasonable to also consider fetch time,
   which more precisely reflects disk perf.
   
   This PR considers both flush and fetch time, and uses ```celeborn.slots.assign.loadAware.flushTimeWeight```
   and ```celeborn.slots.assign.loadAware.fetchTimeWeight``` for flush/fetch time weight respectively.
   
   
   ### Why are the changes needed?
   As above.
   
   
   ### Does this PR introduce _any_ user-facing change?
   Yes, adds two more configs: ```celeborn.slots.assign.loadAware.flushTimeWeight```
   and ```celeborn.slots.assign.loadAware.fetchTimeWeight```.
   
   
   ### How was this patch tested?
   UT and regression.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] waitinfuture merged pull request #1287: [CELEBORN-348] Support fetchTime in load-aware slots assignment strategy

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1287:
URL: https://github.com/apache/incubator-celeborn/pull/1287


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1287: [CELEBORN-348] Support fetchTime in load-aware slots assignment strategy

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1287:
URL: https://github.com/apache/incubator-celeborn/pull/1287#issuecomment-1451188436

   I have run regression and results is as expected. My Celeborn cluster is heterogeneous, 6 of them have better disks and 4 of them have poorer disks. The following snapshot is slots allocated per worker, and we can see the workers with better disks are allocated more slots than poor ones as time goes.
   ![image](https://user-images.githubusercontent.com/948245/222317304-3fff03e1-92b8-44d8-9d95-c837af9b8e66.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1287: [CELEBORN-348] Support fetchTime in load-aware slots assignment strategy

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #1287:
URL: https://github.com/apache/incubator-celeborn/pull/1287#discussion_r1122754513


##########
common/src/main/scala/org/apache/celeborn/common/meta/TimeWindow.scala:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.common.meta
+
+import java.util.concurrent.atomic.LongAdder
+
+class TimeWindow(windowSize: Int, minWindowCount: Int) {

Review Comment:
   IMO there is a weak connection with time. Maybe naming it LimitedSlidingWindowReservoir would be better. 



##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -725,9 +729,9 @@ class CelebornConf(loadDefaults: Boolean) extends Cloneable with Logging with Se
   def hddFlusherThreads: Int = get(WORKER_FLUSHER_HDD_THREADS)
   def ssdFlusherThreads: Int = get(WORKER_FLUSHER_SSD_THREADS)
   def hdfsFlusherThreads: Int = get(WORKER_FLUSHER_HDFS_THREADS)
-  def avgFlushTimeSlidingWindowSize: Int = get(WORKER_FLUSHER_AVGFLUSHTIME_SLIDINGWINDOW_SIZE)
-  def avgFlushTimeSlidingWindowMinCount: Int =
-    get(WORKER_FLUSHER_AVGFLUSHTIME_SLIDINGWINDOW_MINCOUNT)
+  def diskTimeSlidingWindowSize: Int = get(WORKER_DISK_TIME_SLIDINGWINDOW_SIZE)

Review Comment:
   DISK_TIME can be renamed to DISKTIME just like other configs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1287: [CELEBORN-348] Support fetchTime in load-aware slots assignment strategy

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1287:
URL: https://github.com/apache/incubator-celeborn/pull/1287#issuecomment-1451189479

   ping @FMX 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1287: [CELEBORN-348] Support fetchTime in load-aware slots assignment strategy

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1287:
URL: https://github.com/apache/incubator-celeborn/pull/1287#issuecomment-1449892380

   # [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1287](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24f914c) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/eda21ead2486c587dba7dc63c26b4df24e8fc866?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eda21ea) will **increase** coverage by `0.67%`.
   > The diff coverage is `42.15%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #1287      +/-   ##
   ============================================
   + Coverage     27.13%   27.80%   +0.67%     
   - Complexity      822      845      +23     
   ============================================
     Files           215      219       +4     
     Lines         18459    18597     +138     
     Branches       1990     2002      +12     
   ============================================
   + Hits           5007     5169     +162     
   + Misses        13125    13073      -52     
   - Partials        327      355      +28     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...a/org/apache/celeborn/common/meta/DeviceInfo.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldGEvRGV2aWNlSW5mby5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...a/org/apache/celeborn/common/meta/TimeWindow.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldGEvVGltZVdpbmRvdy5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...a/org/apache/celeborn/common/meta/WorkerInfo.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldGEvV29ya2VySW5mby5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...org/apache/celeborn/common/util/PbSerDeUtils.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3V0aWwvUGJTZXJEZVV0aWxzLnNjYWxh) | `0.00% <0.00%> (ø)` | |
   | [...apache/celeborn/service/deploy/master/Master.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvbWFzdGVyL01hc3Rlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...born/common/network/server/ChunkStreamManager.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvQ2h1bmtTdHJlYW1NYW5hZ2VyLmphdmE=) | `38.89% <42.86%> (-2.28%)` | :arrow_down: |
   | [...leborn/service/deploy/worker/storage/Flusher.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL3N0b3JhZ2UvRmx1c2hlci5zY2FsYQ==) | `59.31% <44.45%> (+5.18%)` | :arrow_up: |
   | [...service/deploy/worker/storage/StorageManager.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL3N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuc2NhbGE=) | `20.54% <50.00%> (+20.54%)` | :arrow_up: |
   | [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `71.60% <75.00%> (-0.12%)` | :arrow_down: |
   | [.../celeborn/service/deploy/worker/FetchHandler.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL0ZldGNoSGFuZGxlci5zY2FsYQ==) | `38.78% <80.00%> (+2.35%)` | :arrow_up: |
   | ... and [13 more](https://codecov.io/gh/apache/incubator-celeborn/pull/1287?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org