You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/05/31 20:22:34 UTC
Review Request 48090: GEODE-1469: correctly handle the step
arguements in http request
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48090/
-----------------------------------------------------------
Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
GEODE-1469: correctly handle the step arguements in http request
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 5ddcc514e2a72a1ec584f2d8755b53df0e59f457
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java f78c6f924f27ce0ca2bae43c3663f97ee9cd4b98
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ConfigCommandsController.java ebacd3d6b9d5a49d5a5e20b7598674d1ba0ea146
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/http/ClientHttpRequest.java 447733d28dc7397ec0d968315152583194bb447f
Diff: https://reviews.apache.org/r/48090/diff/
Testing
-------
prechecking running
Thanks,
Jinmei Liao
Re: Review Request 48090: GEODE-1469: correctly handle the step
arguements in http request
Posted by Jinmei Liao <ji...@pivotal.io>.
> On May 31, 2016, 9:55 p.m., Jens Deppe wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java, line 1955
> > <https://reviews.apache.org/r/48090/diff/1/?file=1402667#file1402667line1955>
> >
> > Did this creep in accidentally?
I thought I could sneek it in :-). It's intentional. this line does nothing for an off-line command.
- Jinmei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48090/#review135689
-----------------------------------------------------------
On May 31, 2016, 8:22 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48090/
> -----------------------------------------------------------
>
> (Updated May 31, 2016, 8:22 p.m.)
>
>
> Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1469: correctly handle the step arguements in http request
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 5ddcc514e2a72a1ec584f2d8755b53df0e59f457
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java f78c6f924f27ce0ca2bae43c3663f97ee9cd4b98
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ConfigCommandsController.java ebacd3d6b9d5a49d5a5e20b7598674d1ba0ea146
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/http/ClientHttpRequest.java 447733d28dc7397ec0d968315152583194bb447f
>
> Diff: https://reviews.apache.org/r/48090/diff/
>
>
> Testing
> -------
>
> prechecking running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 48090: GEODE-1469: correctly handle the step
arguements in http request
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48090/#review135689
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java
<https://reviews.apache.org/r/48090/#comment200708>
Did this creep in accidentally?
- Jens Deppe
On May 31, 2016, 8:22 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48090/
> -----------------------------------------------------------
>
> (Updated May 31, 2016, 8:22 p.m.)
>
>
> Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1469: correctly handle the step arguements in http request
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 5ddcc514e2a72a1ec584f2d8755b53df0e59f457
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java f78c6f924f27ce0ca2bae43c3663f97ee9cd4b98
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ConfigCommandsController.java ebacd3d6b9d5a49d5a5e20b7598674d1ba0ea146
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/http/ClientHttpRequest.java 447733d28dc7397ec0d968315152583194bb447f
>
> Diff: https://reviews.apache.org/r/48090/diff/
>
>
> Testing
> -------
>
> prechecking running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 48090: GEODE-1469: correctly handle the step
arguements in http request
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48090/#review135949
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On June 1, 2016, 6:38 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48090/
> -----------------------------------------------------------
>
> (Updated June 1, 2016, 6:38 p.m.)
>
>
> Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1469: correctly handle the step arguements in http request
>
> rework. Turns out we need the expand operation of the UriComponents (some of our uri do have variables in them). Rework by ending and decoding the stepArgs
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 5ddcc514e2a72a1ec584f2d8755b53df0e59f457
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/multistep/CLIMultiStepHelper.java 393f09bc7d92b61a24afdb8e3d4602488864f492
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java f78c6f924f27ce0ca2bae43c3663f97ee9cd4b98
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ConfigCommandsController.java ebacd3d6b9d5a49d5a5e20b7598674d1ba0ea146
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/support/LoginHandlerInterceptor.java cefec91f74b499a60b21961dbbe997532a00da1d
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/http/ClientHttpRequest.java 447733d28dc7397ec0d968315152583194bb447f
>
> Diff: https://reviews.apache.org/r/48090/diff/
>
>
> Testing
> -------
>
> prechecking running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 48090: GEODE-1469: correctly handle the step
arguements in http request
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48090/
-----------------------------------------------------------
(Updated June 1, 2016, 6:38 p.m.)
Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund.
Repository: geode
Description (updated)
-------
GEODE-1469: correctly handle the step arguements in http request
rework. Turns out we need the expand operation of the UriComponents (some of our uri do have variables in them). Rework by ending and decoding the stepArgs
Diffs (updated)
-----
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 5ddcc514e2a72a1ec584f2d8755b53df0e59f457
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/multistep/CLIMultiStepHelper.java 393f09bc7d92b61a24afdb8e3d4602488864f492
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java f78c6f924f27ce0ca2bae43c3663f97ee9cd4b98
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ConfigCommandsController.java ebacd3d6b9d5a49d5a5e20b7598674d1ba0ea146
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/support/LoginHandlerInterceptor.java cefec91f74b499a60b21961dbbe997532a00da1d
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/http/ClientHttpRequest.java 447733d28dc7397ec0d968315152583194bb447f
Diff: https://reviews.apache.org/r/48090/diff/
Testing
-------
prechecking running
Thanks,
Jinmei Liao