[GitHub] [maven-jlink-plugin] struberg commented on pull request #23: [MJLINK-57] Migrate to slf4j

[GitBox <gi...@apache.org>]

struberg commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740632700


   Hmm, to be honest - I still see no reason to use slf4j over our very own logging API.
   The discussion is very old actually, and I never was a fan of dropping our own classes in favour to some external dependencies. Did serve us very badly for quite a few cases over the years. Any class we explose in the classloader might create class clashes. The slf4j-api is rather stable, but even there there HAVE been bytecode incompatible changes. And then you need to do all sorts of crazy custom UrlClassLoaders with filtering inbetween just to not create classpath clashes with the projects being built. All that can be spared if we solely only expose and use our very own internal API and then (isolated in the very core) delegate to whatever logging backend we want.
   
   See https://issues.apache.org/jira/browse/MNG-7045 for a very similar issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org