You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2022/08/23 17:55:36 UTC

[spark] branch branch-3.3 updated: [SPARK-40172][ML][TESTS] Temporarily disable flaky test cases in ImageFileFormatSuite

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.3 by this push:
     new 6572c66d01e [SPARK-40172][ML][TESTS] Temporarily disable flaky test cases in ImageFileFormatSuite
6572c66d01e is described below

commit 6572c66d01e3db00858f0b4743670a1243d3c44f
Author: Gengliang Wang <ge...@apache.org>
AuthorDate: Mon Aug 22 16:16:03 2022 +0900

    [SPARK-40172][ML][TESTS] Temporarily disable flaky test cases in ImageFileFormatSuite
    
    ### What changes were proposed in this pull request?
    
    3 test cases in ImageFileFormatSuite become flaky in the GitHub action tests:
    
    https://github.com/apache/spark/runs/7941765326?check_suite_focus=true
    https://github.com/gengliangwang/spark/runs/7928658069
    
    Before they are fixed(https://issues.apache.org/jira/browse/SPARK-40171), I suggest disabling them in OSS.
    
    ### Why are the changes needed?
    
    Disable flaky tests before they are fixed. The test cases keep failing from time to time, while they always pass on local env.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    ### How was this patch tested?
    
    Existing CI
    
    Closes #37605 from gengliangwang/disableFlakyTest.
    
    Authored-by: Gengliang Wang <ge...@apache.org>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
    (cherry picked from commit 50f2f506327b7d51af9fb0ae1316135905d2f87d)
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 .../org/apache/spark/ml/source/image/ImageFileFormatSuite.scala  | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/mllib/src/test/scala/org/apache/spark/ml/source/image/ImageFileFormatSuite.scala b/mllib/src/test/scala/org/apache/spark/ml/source/image/ImageFileFormatSuite.scala
index 10b9bbb0bfe..7981296e210 100644
--- a/mllib/src/test/scala/org/apache/spark/ml/source/image/ImageFileFormatSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/ml/source/image/ImageFileFormatSuite.scala
@@ -49,7 +49,8 @@ class ImageFileFormatSuite extends SparkFunSuite with MLlibTestSparkContext {
     assert(df.schema("image").dataType == columnSchema, "data do not fit ImageSchema")
   }
 
-  test("image datasource count test") {
+  // TODO(SPARK-40171): Re-enable the following flaky test case after being fixed.
+  ignore("image datasource count test") {
     val df1 = spark.read.format("image").load(imagePath)
     assert(df1.count === 9)
 
@@ -87,7 +88,8 @@ class ImageFileFormatSuite extends SparkFunSuite with MLlibTestSparkContext {
     assert(result === invalidImageRow(resultOrigin))
   }
 
-  test("image datasource partition test") {
+  // TODO(SPARK-40171): Re-enable the following flaky test case after being fixed.
+  ignore("image datasource partition test") {
     val result = spark.read.format("image")
       .option("dropInvalid", true).load(imagePath)
       .select(substring_index(col("image.origin"), "/", -1).as("origin"), col("cls"), col("date"))
@@ -105,8 +107,9 @@ class ImageFileFormatSuite extends SparkFunSuite with MLlibTestSparkContext {
     ))
   }
 
+  // TODO(SPARK-40171): Re-enable the following flaky test case after being fixed.
   // Images with the different number of channels
-  test("readImages pixel values test") {
+  ignore("readImages pixel values test") {
     val images = spark.read.format("image").option("dropInvalid", true)
       .load(imagePath + "/cls=multichannel/").collect()
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org