You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/03/25 14:59:07 UTC

[GitHub] [zookeeper] eolivelli commented on a change in pull request #860: ZOOKEEPER-3324: Add read/write metrics for top level znodes

eolivelli commented on a change in pull request #860: ZOOKEEPER-3324: Add read/write metrics for top level znodes
URL: https://github.com/apache/zookeeper/pull/860#discussion_r268683445
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java
 ##########
 @@ -690,17 +705,25 @@ public Stat statNode(String path, Watcher watcher)
         if (n == null) {
             throw new KeeperException.NoNodeException();
         }
+        List<String> children;
         synchronized (n) {
             if (stat != null) {
                 n.copyStat(stat);
             }
-            List<String> children=new ArrayList<String>(n.getChildren());
+            children=new ArrayList<String>(n.getChildren());
 
 Review comment:
   nit: add spaces around '='

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services