DO NOT REPLY [Bug 13570] New: - tag pooling not working

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13570>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13570

tag pooling not working

           Summary: tag pooling not working
           Product: Tomcat 4
           Version: 4.1.12
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Jasper 2
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: kip3f@yahoo.com


I created a simple page with one EMPTY bodycontent JSP tag in it, and I wanted
to look in the source to see if Tomcat was doing any sort of pooling of tag
objects.  I find the following code:

    int _jspx_eval_kw_render_0 = _jspx_th_kw_render_0.doStartTag();
    if (_jspx_th_kw_render_0.doEndTag() == javax.servlet.jsp.tagext.Tag.SKIP_PAGE)
      return true;
    _jspx_tagPool_kw_render_name.reuse(_jspx_th_kw_render_0);
    return false;
This doesn't return the tag to the pool if it behaves properly!  It also doesn't
call the release() method, so this is a compliance bug, also.

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>