You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2022/04/03 15:20:28 UTC

[hbase] 01/04: HBASE-26916 Fix missing braces warnings in DefaultVisibilityExpressionResolver (#4313)

This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/hbase.git

commit 92734749dd8807f12b2198211c57b44a2e1436bd
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Sun Apr 3 22:42:17 2022 +0800

    HBASE-26916 Fix missing braces warnings in DefaultVisibilityExpressionResolver (#4313)
    
    Signed-off-by: Xiaolin Ha <ha...@apache.org>
    (cherry picked from commit c4ff355915f27bacefe1c8f9fa1a7c4cab6a825b)
---
 .../hbase/mapreduce/DefaultVisibilityExpressionResolver.java       | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java b/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java
index 07f05dd..620c02e 100644
--- a/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java
+++ b/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java
@@ -98,7 +98,9 @@ public class DefaultVisibilityExpressionResolver implements VisibilityExpression
       } catch (IOException e) {
         LOG.error("Error scanning 'labels' table", e);
       } finally {
-        if (scanner != null) scanner.close();
+        if (scanner != null) {
+          scanner.close();
+        }
       }
     } catch (IOException ioe) {
       LOG.error("Failed reading 'labels' tags", ioe);
@@ -111,12 +113,13 @@ public class DefaultVisibilityExpressionResolver implements VisibilityExpression
           LOG.warn("Error closing 'labels' table", ioe);
         }
       }
-      if (connection != null)
+      if (connection != null) {
         try {
           connection.close();
         } catch (IOException ioe) {
           LOG.warn("Failed close of temporary connection", ioe);
         }
+      }
     }
   }