[GitHub] [phoenix] virajjasani commented on a change in pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#discussion_r598461392



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
##########
@@ -496,6 +496,10 @@ private static void optimizeProjection(StatementContext context, Scan scan, PTab
                         trackedColumnsBitset.set(qualifier);
                     }
                 }
+            } else {
+                // cannot use EncodedQualifiersColumnProjectionFilter in this case
+                // since there's an unknown set of qualifiers (cf.*)
+                trackedColumnsBitset = null;

Review comment:
       Yeah I think this makes sense, and hopefully should work for multiple filters too. Shall we add one more test to cover multiple cols and filters? Something like
   `SELECT w.*, x.* FROM tableName WHERE y.v2='xyz' and z.v3='abc'` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org