You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/08/26 07:16:33 UTC

[GitHub] [calcite] cuglifangzheng commented on a change in pull request #2121: [CALCITE-4192]fix aggregate column origins searching by RelMdColumnOrigins

cuglifangzheng commented on a change in pull request #2121:
URL: https://github.com/apache/calcite/pull/2121#discussion_r477084585



##########
File path: core/src/test/java/org/apache/calcite/test/RelMdColumnOriginsTest.java
##########
@@ -74,4 +78,25 @@
     statement.close();
     connection.close();
   }
+

Review comment:
       ok, I will try it ,thanks! I thought i was testing RelMdColumnOrigins, so ...
   
   > Extending from `SqlToRelConverterTest` is not a good idea, why not move the test case directly into `RelOptRulesTest` ?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org