You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/08/22 07:51:45 UTC
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #171: fix all module test code style
kaijchen commented on code in PR #171:
URL: https://github.com/apache/incubator-uniffle/pull/171#discussion_r951115502
##########
pom.xml:
##########
@@ -799,18 +799,21 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${maven-checkstyle-plugin.version}</version>
<configuration>
- <sourceDirectories>
- <directory>${basedir}/src/main/java</directory>
- </sourceDirectories>
- <testSourceDirectories>
- <directory>${basedir}/src/test/java</directory>
- </testSourceDirectories>
+<!-- <sourceDirectories>-->
Review Comment:
Please remove commented code here.
##########
pom.xml:
##########
@@ -799,18 +799,21 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${maven-checkstyle-plugin.version}</version>
<configuration>
- <sourceDirectories>
- <directory>${basedir}/src/main/java</directory>
- </sourceDirectories>
- <testSourceDirectories>
- <directory>${basedir}/src/test/java</directory>
- </testSourceDirectories>
+<!-- <sourceDirectories>-->
+<!-- <directory>${basedir}/src/main/java</directory>-->
+<!-- </sourceDirectories>-->
+<!-- <testSourceDirectories>-->
+<!-- <directory>${basedir}/src/test/java</directory>-->
+<!-- </testSourceDirectories>-->
<configLocation>checkstyle.xml</configLocation>
+ <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
<encoding>UTF-8</encoding>
<consoleOutput>true</consoleOutput>
<failsOnError>true</failsOnError>
<linkXRef>false</linkXRef>
<failOnViolation>true</failOnViolation>
+ <includeTestSourceDirectory>true</includeTestSourceDirectory>
+ <violationSeverity>warning</violationSeverity>
Review Comment:
Please revert this line.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org