You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Gary Helmling (JIRA)" <ji...@apache.org> on 2017/02/02 01:08:52 UTC

[jira] [Commented] (HBASE-17346) Add coprocessor service support

    [ https://issues.apache.org/jira/browse/HBASE-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849208#comment-15849208 ] 

Gary Helmling commented on HBASE-17346:
---------------------------------------

Took a look after the fact.  +1

Looks good to me.  At first glance, I thought that passing a stubMaker function for every call would be a little cumbersome, but in practice I think it works well.  It's more intentional and not much longer than just giving the service class, and allows more flexibility if needed.

> Add coprocessor service support
> -------------------------------
>
>                 Key: HBASE-17346
>                 URL: https://issues.apache.org/jira/browse/HBASE-17346
>             Project: HBase
>          Issue Type: Sub-task
>          Components: asyncclient, Client, Coprocessors
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: 17346.suggestion.txt, HBASE-17346.patch, HBASE-17346-v1.patch, HBASE-17346-v2.patch, HBASE-17346-v3.patch, HBASE-17346-v4.patch, HBASE-17346-v5.patch
>
>
> I think we need to redesign the API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)