You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/09/20 06:47:19 UTC
[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #3129: test(binding/java): add behavior test framework for java
tisonkun commented on code in PR #3129:
URL: https://github.com/apache/incubator-opendal/pull/3129#discussion_r1331081875
##########
.github/workflows/service_test_redis.yml:
##########
@@ -192,3 +192,26 @@ jobs:
OPENDAL_REDIS_ENDPOINT: tcp://127.0.0.1:6379
OPENDAL_REDIS_ROOT: /
OPENDAL_REDIS_DB: 0
+
+ binding_java_redis:
Review Comment:
> Is it possible to make it a matrix so that we can test core, binding/java, bindings/python, ...?
It's possible but I'm afraid that we need a lot of if-else to handle the setup and teardown logics for different languages.
Perhaps we can factor out the service setup as a reuseable workflow/action and refer them in each specific language's job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org