You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by jl...@apache.org on 2019/05/02 17:07:02 UTC

[incubator-pinot] branch master updated: Clean up unused variable in ControllerLeadershipManager (#4181)

This is an automated email from the ASF dual-hosted git repository.

jlli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new ac19af7  Clean up unused variable in ControllerLeadershipManager (#4181)
ac19af7 is described below

commit ac19af76d34333a8259536ac56d0c7fd3730cec5
Author: Jialiang Li <jl...@linkedin.com>
AuthorDate: Thu May 2 10:06:56 2019 -0700

    Clean up unused variable in ControllerLeadershipManager (#4181)
---
 .../java/org/apache/pinot/controller/ControllerLeadershipManager.java | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/ControllerLeadershipManager.java b/pinot-controller/src/main/java/org/apache/pinot/controller/ControllerLeadershipManager.java
index 46160c6..31eef72 100644
--- a/pinot-controller/src/main/java/org/apache/pinot/controller/ControllerLeadershipManager.java
+++ b/pinot-controller/src/main/java/org/apache/pinot/controller/ControllerLeadershipManager.java
@@ -34,9 +34,6 @@ public class ControllerLeadershipManager {
 
   private static final Logger LOGGER = LoggerFactory.getLogger(ControllerLeadershipManager.class);
 
-  // TODO: fix the misuse of singleton.
-  private static ControllerLeadershipManager INSTANCE = null;
-
   private HelixManager _helixManager;
   private volatile boolean _amILeader = false;
 
@@ -54,7 +51,6 @@ public class ControllerLeadershipManager {
     if (_amILeader) {
       onBecomingNonLeader();
     }
-    INSTANCE = null;
   }
 
   /**


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org