You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/30 11:35:53 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #13377: Bugfix: Sync Access Control defined in DAGs when running sync-perm

kaxil commented on a change in pull request #13377:
URL: https://github.com/apache/airflow/pull/13377#discussion_r550163725



##########
File path: tests/cli/commands/test_sync_perm_command.py
##########
@@ -51,6 +56,7 @@ def test_cli_sync_perm(self, dagbag_mock, mock_cached_app):
         assert appbuilder.sm.sync_roles.call_count == 1
 
         dagbag_mock.assert_called_once_with(read_dags_from_db=True)
+        collect_dags_from_db_mock.assert_called_once_with()

Review comment:
       Does not matter much tbh, `assert_called_once_with()` is a superset of `assert_called_once`, in this case it just checks that it is called with no args.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org