You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/26 12:31:47 UTC
[GitHub] [arrow-rs] HaoYang670 opened a new pull request, #1752: Rename the `string` kernel to `concat_elements`.
HaoYang670 opened a new pull request, #1752:
URL: https://github.com/apache/arrow-rs/pull/1752
Signed-off-by: remzi <13...@gmail.com>
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1747.
# Rationale for this change
Please see the issue.
# Are there any user-facing changes?
Yes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1752: Rename the `string` kernel to `concat_elements`.
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1752:
URL: https://github.com/apache/arrow-rs/pull/1752#issuecomment-1138885044
Or maybe just `concat_string` would enough 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on pull request #1752: Rename the `string` kernel to `concat_elements`.
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on PR #1752:
URL: https://github.com/apache/arrow-rs/pull/1752#issuecomment-1139130219
Thank you for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1752: Rename the `string` kernel to `concat_elements`.
Posted by GitBox <gi...@apache.org>.
alamb merged PR #1752:
URL: https://github.com/apache/arrow-rs/pull/1752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1752: Rename the `string` kernel to `concat_elements`.
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1752:
URL: https://github.com/apache/arrow-rs/pull/1752#issuecomment-1138893430
Proposed change in https://github.com/apache/arrow-rs/pull/1754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #1752: Rename the `string` kernel to `concat_elements`.
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #1752:
URL: https://github.com/apache/arrow-rs/pull/1752#issuecomment-1138724644
Perhaps we should rename the function `string_concat` to `concat_elements_string` to be consistent with other modules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1752: Rename the `string` kernel to `concat_elements`.
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1752:
URL: https://github.com/apache/arrow-rs/pull/1752#issuecomment-1138884340
> Perhaps we should rename the function string_concat to concat_elements_string to be consistent with other modules?
This would be an excellent thing to do - I'll try and get it done later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org