[jira] [Commented] (OFBIZ-11098) methods not accessing ‘this’ should be ‘static’

["Mathieu Lirzin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-11098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859972#comment-16859972 ] 

Mathieu Lirzin commented on OFBIZ-11098:
----------------------------------------

Committed  [^OFBIZ-11098_framework.patch]  on trunk framework with revision 1860937.
Committed  [^OFBIZ-11098_plugins.patch] on trunk plugins with revision 1860939.

Those commits only affects the private methods so they should be safe.  There are 12 remaining instances of methods that should have a {{static}} modifier. However since those method are marked as {{public}} there are not safe since they can be accessed non-locally. I will check more closely before fixing those.

> methods not accessing ‘this’ should be ‘static’
> -----------------------------------------------
>
>                 Key: OFBIZ-11098
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11098
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL PLUGINS, framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-11098_framework.patch, OFBIZ-11098_plugins.patch
>
>
> In order to make it clear when a method is not depending on the internal state of an object, it is a good practice to declare it as {{static}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)