You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/01/19 19:30:47 UTC
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9079
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
In the previous fix for IMPALA-6399 we increased the number of retries.
However, there was a bug in the retry logic that would prevent it from
sleeping when the profile was not available yet.
This change now switches to a time-based wait-loop instead of a set
number of retries. It also moves the sleep() to the beginning of the
loop to make it less likely to forget the it when changing the code in
the future. Calling sleep() before trying to fetch the profile for the
first time also reduces the likelihood of hitting a warning when the
profile is not yet available.
We also change the timeout back to 60 seconds which should be enough for
the profile to show up.
Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
---
M tests/query_test/test_observability.py
1 file changed, 15 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9079/1
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Zoram Thanga, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9079
to look at the new patch set (#5).
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
In the previous fix for IMPALA-6399 we increased the number of retries.
However, there was a bug in the retry logic: If the profile was missing,
we would call 'continue' without sleeping, thus eating through the
maximum number of retries in a short period of time.
This change now switches to a time-based wait-loop instead of a set
number of retries. It also moves the sleep() to the beginning of the
loop to make it less likely to forget it when changing the code in the
future. Calling sleep() before trying to fetch the profile for the first
time also reduces the likelihood of hitting a warning when the profile
is not yet available.
Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
---
M tests/query_test/test_observability.py
1 file changed, 17 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9079/5
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1766/
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2018 22:57:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 8: Verified+1 Code-Review+2
Addressed Sailesh's comment. Carrying Sailesh's +2 and Jenkins's +1.
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 18:42:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 1:
(1 comment)
Thanks for the review, please see PS2.
http://gerrit.cloudera.org:8080/#/c/9079/1/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:
http://gerrit.cloudera.org:8080/#/c/9079/1/tests/query_test/test_observability.py@164
PS1, Line 164: elapsed = time.time() - (end - MAX_WAIT)
> Can you add start = time.time() at L146, and use that to calculate the elap
Done
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2018 20:22:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 9: Verified+1 Code-Review+2
Addressed Sailesh's comment. Carrying Sailesh's +2 and Jenkins's +1, this time on PS9.
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 9
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 18:42:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Zoram Thanga,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9079
to look at the new patch set (#3).
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
In the previous fix for IMPALA-6399 we increased the number of retries.
However, there was a bug in the retry logic: If the profile was missing,
we would call 'continue' without sleeping, thus eating through the
maximum number of retries in a short period of time.
This change now switches to a time-based wait-loop instead of a set
number of retries. It also moves the sleep() to the beginning of the
loop to make it less likely to forget it when changing the code in the
future. Calling sleep() before trying to fetch the profile for the first
time also reduces the likelihood of hitting a warning when the profile
is not yet available.
We also change the timeout back to 60 seconds which should be enough for
the profile to show up.
Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
---
M tests/query_test/test_observability.py
1 file changed, 16 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9079/3
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 1:
Zoram, as the original author of the code, could you please have a look?
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2018 19:31:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Zoram Thanga (Code Review)" <ge...@cloudera.org>.
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jan 2018 19:15:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9079/8/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:
http://gerrit.cloudera.org:8080/#/c/9079/8/tests/query_test/test_observability.py@136
PS8, Line 136: @pytest.mark.execute_serially
nit: Could you add "Run this test serially to avoid a delay over the wait time in fetching the profile" ?
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 17:19:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Zoram Thanga (Code Review)" <ge...@cloudera.org>.
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 1:
(1 comment)
Thanks for fixing this.
http://gerrit.cloudera.org:8080/#/c/9079/1/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:
http://gerrit.cloudera.org:8080/#/c/9079/1/tests/query_test/test_observability.py@164
PS1, Line 164: elapsed = time.time() - (end - MAX_WAIT)
Can you add start = time.time() at L146, and use that to calculate the elapsed time instead? It would be more obvious that way.
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2018 19:50:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 3: Code-Review+2
(3 comments)
Thanks for the reviews. I addressed all comments in PS3. Carrying Sailesh's +2.
http://gerrit.cloudera.org:8080/#/c/9079/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9079/2//COMMIT_MSG@10
PS2, Line 10: there was a bug in the retry logic
> Could you also briefly add what this bug was in the commit message?
Done
http://gerrit.cloudera.org:8080/#/c/9079/2//COMMIT_MSG@15
PS2, Line 15: oves the sleep()
> typo
Done
http://gerrit.cloudera.org:8080/#/c/9079/2/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:
http://gerrit.cloudera.org:8080/#/c/9079/2/tests/query_test/test_observability.py@151
PS2, Line 151: introduce an error below
> I don't think that it's important to state this line. But if you feel like
Done
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2018 22:57:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Zoram Thanga, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9079
to look at the new patch set (#4).
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
In the previous fix for IMPALA-6399 we increased the number of retries.
However, there was a bug in the retry logic: If the profile was missing,
we would call 'continue' without sleeping, thus eating through the
maximum number of retries in a short period of time.
This change now switches to a time-based wait-loop instead of a set
number of retries. It also moves the sleep() to the beginning of the
loop to make it less likely to forget it when changing the code in the
future. Calling sleep() before trying to fetch the profile for the first
time also reduces the likelihood of hitting a warning when the profile
is not yet available.
Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
---
M tests/query_test/test_observability.py
1 file changed, 16 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9079/4
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 05:13:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Zoram Thanga, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9079
to look at the new patch set (#7).
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
In the previous fix for IMPALA-6399 we increased the number of retries.
However, there was a bug in the retry logic: If the profile was missing,
we would call 'continue' without sleeping, thus eating through the
maximum number of retries in a short period of time.
This change now switches to a time-based wait-loop instead of a set
number of retries. It also moves the sleep() to the beginning of the
loop to make it less likely to forget it when changing the code in the
future. Calling sleep() before trying to fetch the profile for the first
time also reduces the likelihood of hitting a warning when the profile
is not yet available.
This change also increases the timeout to 300 seconds and marks the test
for serial execution to decrease the likelihood of races.
Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
---
M tests/query_test/test_observability.py
1 file changed, 18 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9079/7
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Zoram Thanga (Code Review)" <ge...@cloudera.org>.
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 4:
I wonder if we should serialize this test as well? It can't seem to get past gvo now.
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Jan 2018 16:36:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Zoram Thanga (Code Review)" <ge...@cloudera.org>.
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 16:27:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Zoram Thanga,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9079
to look at the new patch set (#2).
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
In the previous fix for IMPALA-6399 we increased the number of retries.
However, there was a bug in the retry logic that would prevent it from
sleeping when the profile was not available yet.
This change now switches to a time-based wait-loop instead of a set
number of retries. It also moves the sleep() to the beginning of the
loop to make it less likely to forget the it when changing the code in
the future. Calling sleep() before trying to fetch the profile for the
first time also reduces the likelihood of hitting a warning when the
profile is not yet available.
We also change the timeout back to 60 seconds which should be enough for
the profile to show up.
Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
---
M tests/query_test/test_observability.py
1 file changed, 16 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9079/2
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 8:
Rebased to get the workaround for IMPALA-6092.
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 01:35:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Zoram Thanga, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9079
to look at the new patch set (#6).
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
In the previous fix for IMPALA-6399 we increased the number of retries.
However, there was a bug in the retry logic: If the profile was missing,
we would call 'continue' without sleeping, thus eating through the
maximum number of retries in a short period of time.
This change now switches to a time-based wait-loop instead of a set
number of retries. It also moves the sleep() to the beginning of the
loop to make it less likely to forget it when changing the code in the
future. Calling sleep() before trying to fetch the profile for the first
time also reduces the likelihood of hitting a warning when the profile
is not yet available.
This change also increases the timeout to 300 seconds and marks the test
for serial execution to decrease the likelihood of races.
Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
---
M tests/query_test/test_observability.py
1 file changed, 17 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9079/6
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 8: Code-Review-2
Still testing this.
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 01:35:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1781/
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 01:35:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9079/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9079/2//COMMIT_MSG@10
PS2, Line 10: there was a bug in the retry logic
Could you also briefly add what this bug was in the commit message?
http://gerrit.cloudera.org:8080/#/c/9079/2//COMMIT_MSG@15
PS2, Line 15: to forget the it
typo
http://gerrit.cloudera.org:8080/#/c/9079/2/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:
http://gerrit.cloudera.org:8080/#/c/9079/2/tests/query_test/test_observability.py@151
PS2, Line 151: introduce an error below
I don't think that it's important to state this line. But if you feel like it's better to keep it, I have a nit:
"...introduce an error below in future changes..."
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2018 22:38:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Zoram Thanga, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9079
to look at the new patch set (#9).
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
In the previous fix for IMPALA-6399 we increased the number of retries.
However, there was a bug in the retry logic: If the profile was missing,
we would call 'continue' without sleeping, thus eating through the
maximum number of retries in a short period of time.
This change now switches to a time-based wait-loop instead of a set
number of retries. It also moves the sleep() to the beginning of the
loop to make it less likely to forget it when changing the code in the
future. Calling sleep() before trying to fetch the profile for the first
time also reduces the likelihood of hitting a warning when the profile
is not yet available.
This change also increases the timeout to 300 seconds and marks the test
for serial execution to decrease the likelihood of races.
Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
---
M tests/query_test/test_observability.py
1 file changed, 20 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/9079/9
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 9
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
In the previous fix for IMPALA-6399 we increased the number of retries.
However, there was a bug in the retry logic: If the profile was missing,
we would call 'continue' without sleeping, thus eating through the
maximum number of retries in a short period of time.
This change now switches to a time-based wait-loop instead of a set
number of retries. It also moves the sleep() to the beginning of the
loop to make it less likely to forget it when changing the code in the
future. Calling sleep() before trying to fetch the profile for the first
time also reduces the likelihood of hitting a warning when the profile
is not yet available.
This change also increases the timeout to 300 seconds and marks the test
for serial execution to decrease the likelihood of races.
Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Reviewed-on: http://gerrit.cloudera.org:8080/9079
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Lars Volker <lv...@cloudera.com>
---
M tests/query_test/test_observability.py
1 file changed, 20 insertions(+), 14 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 10
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 8: -Code-Review
Sailesh, Zoram, this now passes. Do you want to have another look?
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 16:17:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 7:
Was missing an import for the pytest decorators. Will run another private dry-run.
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jan 2018 23:53:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Zoram Thanga (Code Review)" <ge...@cloudera.org>.
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2018 20:24:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1766/
--
To view, visit http://gerrit.cloudera.org:8080/9079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389
Gerrit-Change-Number: 9079
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Jan 2018 02:28:19 +0000
Gerrit-HasComments: No